Giter Site home page Giter Site logo

Update source data? about nodamoney HOT 4 OPEN

automatevalue avatar automatevalue commented on May 20, 2024
Update source data?

from nodamoney.

Comments (4)

RemyDuijkeren avatar RemyDuijkeren commented on May 20, 2024

Which differences do you see?

The basic source is indeed from Wikipedia. I did a cross check and there seems to be a couple of differences and see the following points:

  1. The colón (SVC) is on the list of ISO, but the colón was the currency of El Salvador between 1892 and 2001. Apparently it is never been officially removed after amendment 115.
  2. Zimbabwe Dollar (ZWL) is also on the list of ISO, but is not used since 2009. This is apparently also still on the ISO list and it looks like it is also not officially been removed.
  3. USS (998) is removed from the list of ISO and also shown in amendment 158, but Wikipedia still has it :-(.

Going to do some checks on these and change Wikipedia and NodaMoney.

from nodamoney.

sliekens avatar sliekens commented on May 20, 2024

I'm worried about the EnglishName. I didn't expect there to be so many differences. For example: USD
Wikipedia: United States dollar
currency-iso.org: US Dollar

I'm tempted to believe that currency-iso.org is closer to the ISO standard than Wikipedia but hell who knows...

from nodamoney.

sliekens avatar sliekens commented on May 20, 2024

It's a bit unfortunate that CurrencyBuilder requires a currency symbol. That's the only thing stopping me from using the XML that currency-iso.org provides instead of the built-in currencies.

I wouldn't mind if Money.ToString would format money using the ISO code instead of the currency symbol if no symbol was specified. In fact, why is this not a feature even when symbols are available?

from nodamoney.

samcic avatar samcic commented on May 20, 2024

The Unicode CLDR is a frequently-recommended source for such information. It is used by many "big name" companies, is well maintained and importantly also includes the information necessary for culture-dependent formatting of currency amounts (e.g. if I'm formatting USD in Sweden I'd expect to see "USD 123,45" rather than "$123.45" which is what I'd see if I were in the US).

Client-side libraries like Globalize are built on the CLDR data and offer these more general formatting options.

On the server side, there doesn't really seem to be anything comparable for .NET. In my case I'm looking for a way to format currencies on the server side (e.g. for sending notification emails with a price in them) using the same CLDR source data as I use on the client.

Anyway, I just thought I'd share my opinion, although I imagine it would represent a considerable amount of work to change things to use the CLDR.

As a side note, I found what appears to be some more out-of-date info in this project w.r.t. the CLDR at least: RSD no longer has fractional units, neither does COP.

from nodamoney.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.