WordPress 4.4 caused menu items to disappear

[mdrovdahl]

WordPress 4.4 caused menu items to disappear

[joshbetz]

I think this is related to Babble clobbering some arguments for already registered post types, here:

https://github.com/Automattic/babble/blob/develop/class-post-public.php#L277-L285

[emrikol]

I think @joshbetz is on to something. Babble is overwriting menu_position when calling register_post_type(), which causes the shadow post types to overwrite the position of the standard post type, and then the shadow post type is removed from the menu in Babble_Post_Public::add_menu_classes()

This can be tested easily with this patch:

Index: class-post-public.php
===================================================================
--- class-post-public.php       (revision 224474)
+++ class-post-public.php       (working copy)
@@ -325,6 +325,9 @@
                                $new_args['capabilities']['create_posts'] = 'do_not_allow';
                        }

+                       // Unset menu_position so that shadow post types won't overwrite post types with a hard coded position.
+                       unset( $new_args['menu_position'] );
+
                        $result = register_post_type( $new_post_type, $new_args );
                        if ( is_wp_error( $result ) ) {
                                bbl_log( "Error creating shadow post_type for $new_post_type: " . print_r( $result, true ), true );

I'm not sure what changed in 4.4 that causes this to happen though.