Giter Site home page Giter Site logo

0.3.7 is broken about cli-table HOT 6 CLOSED

zloirock avatar zloirock commented on June 20, 2024 2
0.3.7 is broken

from cli-table.

Comments (6)

zloirock avatar zloirock commented on June 20, 2024

https://github.com/zloirock/core-js/runs/4240992349?check_suite_focus=true

from cli-table.

dmeeks91 avatar dmeeks91 commented on June 20, 2024

Can confirm that I am seeing the same error.

This line will throw an error if typeof stripped != "string"
Looks like PR #149 introduced a scenario where this constraint is not met. I'm guessing this is when the bug was introduced.

I haven't studied the code enough to determine if the preferred solution is to type check in the strlen utility function or revert the recently merged PR.

from cli-table.

pomek avatar pomek commented on June 20, 2024

I face the same issue. In my case, I decided to cast all numbers I pass into the table to strings. It helped.

from cli-table.

adrianosmond avatar adrianosmond commented on June 20, 2024

var stripped = ("" + str).replace(code,'');
was changed to
var stripped = stripAnsi(str);

so numbers aren't getting converted to strings before stripping them. Maybe
var stripped = stripAnsi("" + str);
would be a friendlier, more backwards compatible approach?

from cli-table.

dreinert1994 avatar dreinert1994 commented on June 20, 2024

This problem is currently crashing my build pipeline as it is a dependency of a dependency for us. I put a PR to try and resolve the issue, hoping to get it reviewed and merged ASAP

from cli-table.

ljharb avatar ljharb commented on June 20, 2024

See #160 - any inclusion of strip-ansi v6 is a breaking change, because it drops support for node < 12, and the v0.3 line claims support for node 0.2+.

from cli-table.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.