Comments (7)
Related issue for non-AMP responsive ads: #51
from newspack-ads.
Might be able to do something with fluid layout, possibly combined with multi-size ads
For example, if we set layout="fluid"
and add the sizes the user has defined as the multi-size parameter, in theory it would render the largest ad of the defined sizes that would fit the screen. Need to test to make sure it won't render ads that are larger than the viewport, though.
from newspack-ads.
The only really good solution here that I've been able to figure out is AMP Plus using the non-AMP ad handling. Then it works nicely. Since this bug doesn't affect in-content ads injected via SCAIP, it's not a huge issue.
from newspack-ads.
I dont think it makes sense to have responsive ad blocks after #98. The logic would get weird. Responsive ad blocks can be achieved where necessary by placing two ad units next to each other and hiding/showing the appropriate unit based on viewport size with some custom CSS.
from newspack-ads.
Since Ad blocks are primarily used on homepages, after further thinking it does make sense to make them responsive. As far as I can tell, there is no ad placement that wouldn't be improved if the ad was responsive.
from newspack-ads.
@claudiulodro I believe this issue has been solved with the recent release of #196 -- are we good to close this issue?
from newspack-ads.
The block was refactored to work with the Placements system and its unified per-provider rendering strategy.
from newspack-ads.
Related Issues (20)
- Add Publisher Media Kit plugin to Add-Ons
- Extend ad suppression to allow suppression on all posts in a single category HOT 3
- Unrecoverable error on launch of ads option HOT 2
- GAM Data Display
- Ad units are getting duplicated when oauth is disconnected HOT 1
- GAM API repeatedly getting disconnected HOT 1
- Value CPM not being properly input
- Add parent path (if detected) to ad unit code HOT 2
- Only display Ad Label setting if AMP Plus enabled HOT 5
- PHP 8: sorting functions update HOT 2
- Fields and script required for ad block recovery messaging HOT 1
- Add custom choice to ad block recovery
- Only show the ad recovery message after a certain number of pageviews
- Don't show ad recovery message to subscriber or donor
- Allow Broadstreet to run in AMP Plus mode
- Fixed height settings not getting applied on placements with multiple hooks
- Restore GAM error messages HOT 2
- Change 160x600 assignment in size mapping rules
- Handle oauth without GAM networks HOT 3
- Request for guidance on displaying Adsense ads. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from newspack-ads.