Responsive AMP ad blocks

[automattic]

Responsive AMP ad blocks

[claudiulodro]

Related issue for non-AMP responsive ads: #51

[claudiulodro]

Might be able to do something with fluid layout, possibly combined with multi-size ads

For example, if we set layout="fluid" and add the sizes the user has defined as the multi-size parameter, in theory it would render the largest ad of the defined sizes that would fit the screen. Need to test to make sure it won't render ads that are larger than the viewport, though.

[claudiulodro]

The only really good solution here that I've been able to figure out is AMP Plus using the non-AMP ad handling. Then it works nicely. Since this bug doesn't affect in-content ads injected via SCAIP, it's not a huge issue.

[claudiulodro]

I dont think it makes sense to have responsive ad blocks after #98. The logic would get weird. Responsive ad blocks can be achieved where necessary by placing two ad units next to each other and hiding/showing the appropriate unit based on viewport size with some custom CSS.

[claudiulodro]

Since Ad blocks are primarily used on homepages, after further thinking it does make sense to make them responsive. As far as I can tell, there is no ad placement that wouldn't be improved if the ad was responsive.

[kmwilkerson]

@claudiulodro I believe this issue has been solved with the recent release of #196 -- are we good to close this issue?

[miguelpeixe]

The block was refactored to work with the Placements system and its unified per-provider rendering strategy.