Comments (4)
I have a user with almost the same issue. I was able to test/confirm on my own Atomic site.
However, a slight difference is A) the user and I weren't using the panel page as the "Front Page" and B) I could only reproduce on Atomic sites.
Steps to replicate
- Activate Shoreditch on an Atomic site.
- Make sure like buttons for the site are turned on under My Site > Sharing
- Create a page with the Panel Page template
- Give that page a few child pages
- Make sure the Like button is turned off for each individual Child Page
- View the Parent Panel Page - like buttons appear on the child panels
- Disable the site like buttons setting and view the panel page again. Like buttons disappear.
As a temporary workaround I gave the user some CSS to hide the like button entirely:
/* Hide Like Button */
#content div.sharedaddy, #main div.sharedaddy, div.sharedaddy {
display: none;
}
With the idea that if they decide later they only want to hide it on pages or somewhere more specific, the CSS could be tweaked so that it's not disabled site-wide.
- User report: 979454-zen
- User's site: https://esthermekkelholt.com/wat-kan-ik/
from themes.
I am able to reproduce this, though it happens regardless of whether the Panel Page is set to the home page or not.
I suspect this is similar to Automattic/jetpack#8990 , in that Likes settings are tied into the page's main query rather than the subsequent child page query.
I'm going to test this theory by applying a similar setup to Affinity, which also uses a separate query on a page to build out the contents.
from themes.
I confirmed that the same thing happens in Affinity, with the following steps to reproduce:
- Activate Affinity.
- Make sure like buttons for the site are turned on under My Site > Sharing.
- Create a couple of Pages, and turn Likes off for those pages.
- Set a Static Front Page under Customize -> Homepage Settings.
- Go to Customize -> Theme Options -> Panel 1 and select one of the pages created in step 3.
- Go to Customize -> Theme Options -> Panel 2 and select the other page created in step 3.
- Publish changes and view your home page. The Likes settings for the individual child pages are not respected; you'll still see Likes enabled, even though they've been turned off for those child pages.
The individual page Likes settings are overruled by the global Likes settings because we're displaying those pages outside the main query. This gets even more complicated when you set a static front page, since that has its own global Likes settings as well.
This is not specific to these themes; it will happen any time we display content outside the main query (I've seen similar tickets with bugs when Likes are enabled/disabled on Featured Content, for example).
I'm going to move this to a Jetpack ticket. The workaround for now is to turn off Likes globally, or to hide them using Custom CSS.
from themes.
Reported in Automattic/jetpack#9002 and included user information for follow-up.
from themes.
Related Issues (20)
- Hever: Hyperlink hover color not using the color set on the block editor HOT 7
- Dorna: Fonts in the editor do not match the live site HOT 3
- [Bug]: Tenku Theme: Blog Posts block not showing the latest post in the front page HOT 3
- Exford: Pullquote no longer having top and bot padding HOT 2
- Together: Typo on sidebar widget description HOT 2
- Cubic: resized Image Blocks displaying incorrect alignment when set to align Left/Right HOT 4
- Colinear: Customizer colors affect post/page editor element styles on Atomic sites HOT 2
- Lodestar: Details Block doesn't show dropdown arrow on any browser besides Safari HOT 2
- Twenty Twelve Image Spacing Issues HOT 2
- Dara: Full Width, No Sidebar template not applyting correctly in pages other than the homepage HOT 2
- Blocks not going full width in page editor Creatio 2 HOT 2
- Rowling theme: Update the social menu option to include support for latest social media icons like Thread, X HOT 2
- Assembler: Tall drop down menus overflow the container and are clipped HOT 2
- Outland theme: Theme no longer matches demo apperance HOT 3
- Work
- Cubic - Tiled Gallery Block - Images are stacked instead of tiled HOT 4
- Spearhead: [Bug] Loading Gutenberg JS on the frontend HOT 1
- Spacer block's height cannot be edited when using the Raw theme HOT 1
- HTTP 500 error when trying to edit page/post with Spearhead (Classic) theme active HOT 4
- Sticky feature not working [Bug]: HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from themes.