Giter Site home page Giter Site logo

Comments (2)

andrewserong avatar andrewserong commented on August 14, 2024

I think the margin rule is coming from quote/theme.scss in Gutenberg due to Lettre using add_theme_support( 'wp-block-styles' );, which has greater specificity than the default layout rules and overrides. Is there a reason why that theme is using the wp-block-styles theme support? My understanding was that it's typical for block themes not to use it as they can generally provide those styles within theme.json instead?

In terms of resolving the conflict from the Gutenberg side, there is a WIP PR in WordPress/gutenberg#57841 from @tellthemachines that will lower the specificity of that margin rule in the Quote block's theme.scss. From the theme side, is it still necessary for the theme to use the wp-block-styles theme support, or could that be removed?

from themes.

maciejpilarski avatar maciejpilarski commented on August 14, 2024

📌 REPRODUCTION RESULTS
– Tested on Simple – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
I was able to reproduce the issue.

📌 ACTIONS
– Triaged

from themes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.