List of issues with the Lettre theme

[pkuliga]

List of issues with the Lettre theme

[alaczek]

Blog title has max-width 360px which looks bad

This one is a little tricky - the 360 max-width seems to be very deliberate here, matching the description and the subscribe box below. Your example is a bit of an edge case of a very long single word, but I agree that longer titles that get broken up into multiple lines will look off as well, and that's much more common.

So in this instance we could:

• leave the max-width as is, and make the heading smaller (maybe use large font size instead of x-large?). I like this option, but changing the font-size would be a noticeable on existing sites, which we typically try to avoid. On the other hand bumping up the font-size back up would still be possible for anyone who prefers it.
• increase the max-width, although not by much (maybe to 400?) - I'm not sure how much of a difference this would make.

@beafialho or @iamtakashi what do you think about this?

No space between “Leave a Reply” and the comment form

This is a comment form issue separate from the theme, and happens only on Atomic. I already reported it here: Automattic/wp-calypso#83991, but I could also push a CSS fix to the theme in the meantime.

Search input on Archive page has no left padding and the text inside it looks weird

The search block has no padding controls (reported here, but little movement on the issue), so I might need to fix this with custom CSS as well.

I'll get on with fixing the rest :)

[alaczek]

In navigation the About page is marked as active when I’m on the home page (previous attempt to fix this: #7167)

In my testing this only happens on Atomic - there's a CSS rule that overrides the theme. I can try adding !important and see if it helps 🫣

[pkuliga]

Thanks for the update @alaczek! Really appreciate it!

Added numbers to issues to make it easier to point them.

Ad 1. Don't bother with it if it's too tricky. My case is pretty special, not sure if it's worth addressing it. Activated this theme on my Simple site (https://pkuliga.wordpress.com/) and it looks fine there.

Ad 2. On my Simple site, it looks ok. Updated the list with your findings, thanks!

Ad 3. This is how it works on my Simple site when I'm on Home page (still broken 😕)

[alaczek]

Ah yes, there is an issue with the nav on simple sites as well. I tried to fix it, but couldn't quite nail what's wrong. I tried a CSS fix, but I don't think it worked.

I merged and deployed the rest of the fixes.

[pkuliga]

Thanks!

My attempt to fix the nav issues: #7670

@alaczek can you take a look?

[alaczek]

Deployed! I think that concludes this issue?

[pkuliga]

Yup, I think we can close it. Thanks for your help!