Comments (7)
Sorry @up1512001 after having done some research it appears that this was intentional, and so we do just need to fix the styles. More detail over on the GB issue.
from themes.
This is an issue with the TT1
theme I checked it's due to this code present in the style.css
file at the 2154 line number.
.wp-block-group:before,
.wp-block-group:after {
content: "";
display: block;
clear: both;
}
before removing this code
![Screenshot 2024-07-09 at 23 35 24](https://private-user-images.githubusercontent.com/75293077/347066755-5daca660-6a6d-4987-9879-e8a854bc33e2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NjUyMTAsIm5iZiI6MTcyMTc2NDkxMCwicGF0aCI6Ii83NTI5MzA3Ny8zNDcwNjY3NTUtNWRhY2E2NjAtNmE2ZC00OTg3LTk4NzktZThhODU0YmMzM2UyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDIwMDE1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA3ZjhjZWZiYjhlYTMwYzk0YzdmNjIzN2NjNDI3MjBlOGQ1NDFhNzExOTBkNzNkM2I5NTM5MDg5ZDE2MWI2NWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.5gJppdgepMNJ9TFzMPSDFUljElAyYVbsp6qYKfW0Rco)
after removing this code
![Screenshot 2024-07-09 at 23 35 50](https://private-user-images.githubusercontent.com/75293077/347066818-9cbfd7df-cf96-4383-8a20-a157ed8d7989.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NjUyMTAsIm5iZiI6MTcyMTc2NDkxMCwicGF0aCI6Ii83NTI5MzA3Ny8zNDcwNjY4MTgtOWNiZmQ3ZGYtY2Y5Ni00MzgzLThhMjAtYTE1N2VkOGQ3OTg5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDIwMDE1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM3YjIzMDRjYWMyYjI3YTY0MjY2NTMxZGEzZmNkYmFkYmM1MzMyMDkzZmUxYTkxZjI4YWZiZGUxNzI2ODgxNjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.GCh7qURCmyk4ChIXqPNjX1PmkDOrkXjW84PH5lKvBog)
from themes.
@up1512001 fix looks like it will probably fix the problem but I don't think it's the correct fix. @mrfoxtalbot is right that this problem doesn't exist in dotorg. It looks to me like the root cause is that the markup output differs between dotorg and dotcom.
dotcom markup
(excess newlines removed)
<div class="wp-block-group is-layout-grid wp-container-core-group-is-layout-1 wp-block-group-is-layout-grid">
<p>First cell</p>
<p>Second cell</p>
<p>Third cell</p>
</div>
dotorg markup
(excess newlines removed)
<div class="wp-block-group"><div class="wp-block-group__inner-container is-layout-grid wp-container-core-group-is-layout-1 wp-block-group-is-layout-grid">
<p>First cell</p>
<p>Second cell</p>
<p>Third cell</p>
</div></div>
The way this works in TT1 on a dotorg site is that the outer div - div.wp-block-group
has the display:block
rule but the inner div - div.wp-block-group__inner-container
has a display:grid
.
For some reason the dotcom output doesn't include the inner div. It looks like it's been added to GB for a long time so I'm not sure why it is not being output yet.
from themes.
@dsas, sorry to keep pinging you but could you take a look to help triage this? Please note that the Grid block is also partially broken in core WordPress/gutenberg#63300 Thank you!
from themes.
Related Issues (20)
- Stage: Color conflicts when switching theme style variations HOT 5
- Dara: Comments Form not loading on Safari when blocks in comments is enabled. HOT 3
- Multiple Classic Themes: Comment Form not Responding when Blocks in Comments in Enabled while on Safari HOT 16
- [Bug]: Antique style variation for Issue doesn't appear to do anything HOT 2
- Site Title Margin Issues on Safari: Capoverso HOT 2
- [Bug]: The deploy-dotorg GH action fails if there is an error with a single theme
- Error 500 when trying to edit post/pages in Seedlet theme HOT 3
- Seedlet: HTTP ERROR 500 when you try to edit a post/page in the block editor HOT 2
- [Various themes: Sketch, Textbook, Rebalance] unable to edit Portfolios - Add New or Edit results in error message "The editor has encountered an unexpected error." HOT 24
- Task: Retire old versions of updated themes
- Radcliffe 2 theme - Customizer error 500 HOT 1
- Russell Theme not Activating HOT 3
- Assember: No way to restore Front Page template if deleted HOT 5
- Hever: Theme no longer respects "Display Site Title and Tagline" in Site Identity HOT 3
- OutNow: Static link in the front page template HOT 1
- Button Outline Not Working on Illustratr Theme HOT 4
- Assembler: Single Choice Option Block's proportion is off/looks squeezed when the theme Assembler is active HOT 4
- Twenty Sixteen: Image Block Alignment Error (Left/Right) HOT 1
- [Exford] Button block preview in the customizer is missing background color
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from themes.