Comments (3)
We were looking at the issue together with @mashikag and it turns out the test is failing because they tried to click the Continue with Google button before it became available (as it is waiting for the nonce to be generated).
from wp-calypso.
Turns out the tests are still failing, on a different part this time:
✕ Enter 2FA challenge if required - Challenge 2 (30003 ms)
● Signup: WordPress.com WPCC > WooCommerce Via Google › Signup via /start/wpcc › Enter 2FA challenge if required - Challenge 2
page.waitForEvent: Timeout 30000ms exceeded while waiting for event "close"
=========================== logs ===========================
waiting for event "close"
============================================================
126 | }
127 |
> 128 | const googlePopupPageClosePromise = googlePopupPage.waitForEvent( 'close' );
| ^
129 |
130 | // Wait until the TOTP code generated by the client
131 | // changes, meaning the 30s window has rolled over.
at Object.waitForEvent (specs/onboarding/signup__woo-google.ts:128:57)
Test Suites: 1 failed, 1 total
Tests: 1 failed, 1 skipped, 5 passed, 7 total
Snapshots: 0 total
Time: 72.595 s, estimated 73 s
→ I am reopening the issue.
from wp-calypso.
We have fixed the above issue in #89007.
However, there's one more broken test (unrelated to our changes). I have created a new issue for it: #89243
from wp-calypso.
Related Issues (20)
- Login: Add email suggestion logic
- Feature Request - Revision History when Resetting Template
- Like block: Remove unnecessary 10px padding from the buttons HOT 2
- Stats: Traffic page shows chart date for site current date but makes request for device current date HOT 2
- Grid Block - Add Stack on Mobile Option
- File download stats not updating on Simple sites HOT 36
- Stuck on the login screen if logged-in users tried to log in again HOT 1
- Continue with Google: Fix failing e2e test (missing "Continue" button click)
- Fix table alignment
- Site Migration: Automatically add hosting plan after user verifying email account HOT 2
- Create the endpoint to save the segmentation survey answers HOT 1
- Create the endpoint to retrieve segmentation survey answers
- Create the endpoint to retrieve the segmentation survey structure HOT 1
- Link user IDs to anonymous segmentation survey responses once the account is created. HOT 1
- Recent image click stats not displaying HOT 9
- Create query to retrieve the survey definition
- Create the selection components based on the final design
- Validate keys when saving segmentation survey answers
- Woo core profiler Jetpack connect screen mobile UI issues
- List: show in progress label
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-calypso.