Giter Site home page Giter Site logo

Comments (3)

ivan-ottinger avatar ivan-ottinger commented on June 11, 2024

We were looking at the issue together with @mashikag and it turns out the test is failing because they tried to click the Continue with Google button before it became available (as it is waiting for the nonce to be generated).

from wp-calypso.

ivan-ottinger avatar ivan-ottinger commented on June 11, 2024

Turns out the tests are still failing, on a different part this time:

 ✕ Enter 2FA challenge if required - Challenge 2 (30003 ms)

  ● Signup: WordPress.com WPCC > WooCommerce Via Google › Signup via /start/wpcc › Enter 2FA challenge if required - Challenge 2

    page.waitForEvent: Timeout 30000ms exceeded while waiting for event "close"
    =========================== logs ===========================
    waiting for event "close"
    ============================================================

      126 | 				}
      127 |
    > 128 | 				const googlePopupPageClosePromise = googlePopupPage.waitForEvent( 'close' );
          | 				                                                    ^
      129 |
      130 | 				// Wait until the TOTP code generated by the client
      131 | 				// changes, meaning the 30s window has rolled over.

      at Object.waitForEvent (specs/onboarding/signup__woo-google.ts:128:57)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 skipped, 5 passed, 7 total
Snapshots:   0 total
Time:        72.595 s, estimated 73 s

→ I am reopening the issue.

from wp-calypso.

ivan-ottinger avatar ivan-ottinger commented on June 11, 2024

We have fixed the above issue in #89007.

However, there's one more broken test (unrelated to our changes). I have created a new issue for it: #89243

from wp-calypso.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.