User Totals Not Displayed Correctly - Updated as Page Loads

[masperber]

User Totals Not Displayed Correctly - Updated as Page Loads

[ivan-ottinger]

Thanks for the ping, @liviopv.

Looks like the issue was unintentionally introduced by this PR: #88369.

The following change should fix it, but I think it would be better if @renancarvalho (👋🏼🙂 Hi!) could take a closer look - since the proposed fix may potentially cause some other regression to the changes introduced in the PR (that I may be unaware of).

diff --git a/client/my-sites/people/team-members/index.tsx b/client/my-sites/people/team-members/index.tsx
index fe5614fc31..f7384b0c68 100644
--- a/client/my-sites/people/team-members/index.tsx
+++ b/client/my-sites/people/team-members/index.tsx
@@ -55,7 +55,7 @@ function TeamMembers( props: Props ) {
 		( obj ) => obj.linked_user_ID === false
 	);
 
-	const membersTotal = nonPendingMembersSorted.length;
+	const membersTotal = data?.total;
 	const addTeamMemberLink = `/people/new/${ site?.slug }`;
 
 	function getPersonRef( user: Member ) {

[masperber]

7978970-zen Initial customer report.

I've reproduced the issue on another site with over 100 users.

[github-actions]

Support References

This comment is automatically generated. Please do not edit it.

• 7978970-zen
• 8318410-zen

[liviopv]

📌 REPRODUCTION RESULTS

• Tested on Simple – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
I didn't have a safe user list to import to test it on my site, but I was able to reproduce the behaviour on the user site and a large P2 like dotcomhappy

📌 ACTIONS

• Triaged

@Automattic/apex is this something you can look into based on your work in the Subscribers page last year?

[rinazrina]

Another user was confused with this: 8318410-zd-a8c

The Users page shows, "You have 100 team members" even though they have 600+ users.