Get path of modified objects in diff?

[automerge]

Get path of modified objects in diff?

[ept]

Hi @aslakhellesoy, sorry for the slow response. This seems like a good idea. I've put an initial implementation here: a9d75d9 — could you give it a try and see if it does what you want?

One caveat about this feature: at present, Automerge allows an object to appear in several places in the tree (i.e. it allows the document to be a DAG), in which case the path will not be unique. In the future I plan to change this (i.e. I want to restrict the structure to always be a tree). With this in mind, I haven't added support for multiple paths; instead, if there are multiple paths to the same object, the current code just picks one arbitrarily. That behaviour is a bit nasty at present, but will make more sense when the tree restriction is in place.

Another caveat: sometimes an object is created and modified before it is linked into the tree. For example, if you do

Automerge.change(state, doc => doc.foo = {bar: 'baz'})

then Automerge first creates an empty map object, assigns the key bar on that object to the value baz, and then links that new object into the root object under key foo. This means that at the time of assignment of the key bar, the object is not yet in the tree, and thus the assignment operation of bar has no path. If this is a problem, we could probably switch the order of operations so that the empty object is linked into the tree first, and then its key is assigned.

What do you think?

[aslakhellesoy]

Hi @ept thanks a lot for this!

I've decided to try using React for now, despite my original reservations. I still think this change could be useful. I'll comment here if/when I get to try it out.

Thanks again

[FUEANGFA]

good

[pvh]

@aslakhellesoy just doing a little issue grooming. Is this something you're still looking at? If not, would you mind closing the issue? Thanks!

[pvh]

Oh, hah, looks like @ept already implemented it. I'll close this.

[aslakhellesoy]

👍