Giter Site home page Giter Site logo

Comments (13)

inmarelibero avatar inmarelibero commented on June 27, 2024

no one?

from avalancheimaginebundle.

avalanche123 avatar avalanche123 commented on June 27, 2024

You should create your own custom filter for that functionality, it should be easy to do so by looking at the thumbnail filter loader and configuration the bundle comes with, let me know if you're having hard time understanding how to use filter loaders. @jmikola wanna chime in and point out filter loader and custom filter examples, I know you did something similar

from avalancheimaginebundle.

inmarelibero avatar inmarelibero commented on June 27, 2024

I saw from the source that only thumbnail filter is actually implemented, and it's a little restrictive, because Imagine library has other functionalities to offer.
Also, in the documentation it's not written anywhere that only this filter is supported. If a user reads "ImagineBundle" I think he expects to be able to use all functionalities.
I prepared this PR: #59, what do you think about that?

from avalancheimaginebundle.

jmikola avatar jmikola commented on June 27, 2024

Sorry for just arriving to the conversation. @inmarelibero, I'm not sure if you still need help, but I think this is what Bulat was suggesting you use for reference: https://github.com/jmikola/JmikolaImagineBundle

I implemented a custom filter there for resizing with Imagine's heighten, increase, scale, widen modes.

from avalancheimaginebundle.

avalanche123 avatar avalanche123 commented on June 27, 2024

@jmikola I like the resize filter, would you be interested in adding that to this bundle? along with docs?

from avalancheimaginebundle.

avalanche123 avatar avalanche123 commented on June 27, 2024

closing the issue

from avalancheimaginebundle.

jmikola avatar jmikola commented on June 27, 2024

Sorry, I didn't check GitHub for the past two days. I will assign this to myself and work on a PR.

IIRC, the only reason I created JmikolaImagineBundle is because we wanted to encourage people to create their own filters instead of relying on this bundle being bloated :)

from avalancheimaginebundle.

avalanche123 avatar avalanche123 commented on June 27, 2024

thanks Jeremy!

from avalancheimaginebundle.

avalanche123 avatar avalanche123 commented on June 27, 2024

@jmikola ping, any progress on this? :)

from avalancheimaginebundle.

inmarelibero avatar inmarelibero commented on June 27, 2024

great, thank you!

from avalancheimaginebundle.

hellomedia avatar hellomedia commented on June 27, 2024

I am confused. so does relative resize only resize down , not up ?

from avalancheimaginebundle.

jmikola avatar jmikola commented on June 27, 2024

It's been more than a while since I looked at this, but relative resizing shouldn't care about the original size of the image. It simply guarantees that the aspect ratio is preserved.

The documentation examples in https://github.com/jmikola/JmikolaImagineBundle#relativeresize (my old bundle) should explain how this works.

from avalancheimaginebundle.

hellomedia avatar hellomedia commented on June 27, 2024

Thanks. I am still a little surprised that small images might be enlarged (blurred) by the resize. I was looking at a way to have bigger images rezied to a max size, with smaller images left untouched. I'll take a deeper look at the code to see how to go about that.

from avalancheimaginebundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.