Comments (2)
Ok, this one wasn't what I thought it was going to be!
Turns out that in the example above, the template bindings don't work even in 11.0.x. The only reason that they appear to work is that the two properties you're binding: Foreground
and FontSize
are inherited properties. The white foreground for example isn't coming from the TemplateBinding
but is being inherited from the Button
. The reason the template bindings don't work is that TextBlock
doesn't have a templated parent! It's not part of the Button
template - it's the button content.
You can test this out by adding a Tag
property on the Button
and trying to sett the TextBlock.Tag
using a TemplateBinding
in a style. The Tag
won't be set on the TextBlock
in either 11.0 or 11.1.
What changed from 11.0.x to 11.1 is that the failing template bindings now cause the default property value to take effect, blocking the inherited value. That behavior was changed for normal bindings in 11.0.0 (see #10189) but TemplateBinding
was missed. #13970 simply made TemplateBinding
have the same behavior as normal bindings.
Given that, I think I'm going to close this with "yes it's a breaking change, but the previous behavior was a bug".
from avalonia.
Bisected and confirmed caused by #13970.
from avalonia.
Related Issues (20)
- Glitchy ListBox when adding items & setting SelectedIndex HOT 5
- When DataGrid is not set to a height, dynamically adding rows will not widen the height HOT 4
- Application doesn't terminate when unhandled exception is thrown from ReactiveCommand handler HOT 3
- EagerParentStackEnumerator is incompatible with XAML built with older avalonia versions HOT 2
- DataGridCollectionView with Filter items dissapear or duplicate
- DataGridTextColumn IsReadOnly will be True after AOT HOT 2
- CustomDrawOperation.Render won't be called if only drawingContext.Custom is present in override Render method HOT 1
- Showing Window from WinForms app doesn't allow text input HOT 3
- Regression in 11.1 Beta2 and RC1 concerning EmbeddableControlRoot's EmbeddableWindow implementation on Windows HOT 5
- PointerTouchPadGestureSwipe not work in macos
- AvaloniaResource inclusion results in erroneous embedding when resources are outside of project folder HOT 2
- Changing the resolution of headless rendering
- D3D11CreateDevice+Hardware crashes and fallback doesn't work HOT 1
- Android SystemBar Icons theme (Light, Dark) in 11.1.0-rc1
- IsHitTestVisible set to false on parent element ignores IsHitTestVisible set to true for child elements
- NullReferenceException in Avalonia.Skia when creating a new Bitmap HOT 1
- Regression in 11.1: MultiValueConverter returning BindingNotification throws InvalidCastException
- Behaviour of !! operator has changed in 11.1 HOT 3
- Tab Key Navigation not working when OverlayPopups is set to true
- System.InvalidOperationException: Neither DBus nor GTK are available on the system HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from avalonia.