Numeric access keys not working

[JouriM2]

Numeric access keys not working

[stevemonaco]

Moving some details from the originating discussion...

For point 1:

Avalonia/src/Avalonia.Base/Input/AccessKeyHandler.cs

Lines 175 to 183 in f140033

	protected virtual void OnKeyDown(object? sender, KeyEventArgs e)
	{
	bool menuIsOpen = MainMenu?.IsOpen == true;
	if (e.KeyModifiers.HasAllFlags(KeyModifiers.Alt) && !e.KeyModifiers.HasAllFlags(KeyModifiers.Control) || menuIsOpen)
	{
	// If any other key is pressed with the Alt key held down, or the main menu is open,
	// find all controls who have registered that access key.
	var text = e.Key.ToString();

e.Key.ToString() returns "D1" for the key (because of the enum) whereas "_1 One" registers "1" in the hotkey map.

For point 2:

This works as expected if you have a Menu, which is the primary use of AccessText. I'm not sure what the intended design is for out-of-menu access keys. You should be able to press the alt key, release it, and continue pressing access keys (with or without alt held down) to navigate. The non-menu access keys return to normal when the menu is closed.

It can be fixed in this area

Avalonia/src/Avalonia.Base/Input/AccessKeyHandler.cs

Lines 211 to 230 in f140033

	protected virtual void OnPreviewKeyUp(object? sender, KeyEventArgs e)
	{
	switch (e.Key)
	{
	case Key.LeftAlt:
	case Key.RightAlt:
	_altIsDown = false;
	if (_ignoreAltUp)
	{
	_ignoreAltUp = false;
	}
	else if (_showingAccessKeys && MainMenu != null)
	{
	MainMenu.Open();
	}
	break;
	}
	}

by placing the following before the break;. Not sure if there are any side-effects.

if (MainMenu is null)
{
    _owner!.ShowAccessKeys = _showingAccessKeys = false;
}