DefaultValueConverter does not work within styles

[viktorspacil]

DefaultValueConverter does not work within styles

[grokys]

Thanks @viktorspacil - yep looks like a regression. The reason I couldn't reproduce is that the command is bound in a style - I didn't try that and seems we have no tests for this case.

The source of the problem is that the XAML compiler is producing a call to CompiledBindingPathBuilder.Method in this case instead of a CompiledBindingPathBuilder.Command even though it should be possible to determine that the method is being bound to a command here.

This worked before the binding refactor because the default value converter even in the case of compiled bindings used MethodToCommandConverter however after the binding refactor, MethodToCommandConverter is only used for reflection bindings as it's marked as RequiresUnreferencedCode.

I think the best fix will be to make the XAML compiler recognise that the binding needs to provide an ICommand and call CompiledBindingPathBuilder.Command.