Project changes

[avatar29a]

Project changes

[avatar29A]

1,2,3,5 - good. 👍
4, 6 - Explain please motivation?

[wo80]

4. Since the urls don't change and aren't supposed to be user configurable, they are perfect candidates for constants.

5. The values in the Constants.resx file are not localizable - they are just constants. The "Artist" value is only used in the Artist class, so why not just write

WebRequestHelper.CreateLookupUrl("artist", id, CreateIncludeQuery(inc))

instead of

WebRequestHelper.CreateLookupUrl(Localization.Constants.Artist, id, CreateIncludeQuery(inc))

The same holds for the other entries (well, some of them aren't even used (Label, Tag)).

[avatar29A]

4. Ok, may be.

5. I do not like to use string literals directly. What if Constant.resx replace on MusicBrainzConstants.cs or something like that ?

[wo80]

Ok. But I think we shouldn't add another class for those constants. What about adding them to the associated class. So Artist class would look something like

public class Artist : Entity
{
    private const string EntityName = "artist";

    // ...
    public async static Task<Artist> GetAsync(string id, params string[] inc)
    {
        return await GetAsync<Artist>(id, WebRequestHelper.CreateLookupUrl(EntityName, id, CreateIncludeQuery(inc)));
    }
    // ...
}

Same for the other affected classes.

[avatar29A]

Ok, good 👍

[wo80]

The latest commits still have the namespace Hqub.MusicBrainz.API. Do you want to keep the API suffix, or should it be dropped?

[deepakyadav]

@wo80 Have you fixed task 1?
I am working on creating a new project in this solution by reusing as many files as possible. If you have not done/started, then I can fix this. So I will be able to reuse files.

[wo80]

@deepakyadav I haven't started yet.