Giter Site home page Giter Site logo

Comments (8)

avinoamr avatar avinoamr commented on June 9, 2024

Thanks @CybMeta. Looking into it.

from bootstrap-carousel-swipe.

CybMeta avatar CybMeta commented on June 9, 2024

Great!! Waiting for news

from bootstrap-carousel-swipe.

avinoamr avatar avinoamr commented on June 9, 2024

@CybMeta Can't reproduce it. Works perfectly for me on Bootstrap 3.2. I tested also on Nexus 5 and iPhone 4. I've committed the testing page (example.html) that I've been using. Can you try it out?

from bootstrap-carousel-swipe.

CybMeta avatar CybMeta commented on June 9, 2024

I've been testing and finally I've made it to work with Bootstrap 3.2.0 by manually calling the carousel with javascript and don't relay in data- attributes. If you remove the manually carousel call from your example you will reproduce the issue. That was not necessary with Bootstrap 3.1.1. I don't know if this should be considered a issue or a requirement.

from bootstrap-carousel-swipe.

happy2deepak avatar happy2deepak commented on June 9, 2024

worked for me in Bootstrap 3.2, but needs to call it again at the page end.
$( ".carousel" ).carousel(});

from bootstrap-carousel-swipe.

CybMeta avatar CybMeta commented on June 9, 2024

I don't know why you have closed this issue. Bootstrap carousel can be used with data- attributes or with manual call, you choose, but your code force you to use one option killing the original Bootstrap behaviour.

from bootstrap-carousel-swipe.

avinoamr avatar avinoamr commented on June 9, 2024

@CybMeta I disagree. You don't need to "kill" the original Bootstrap behavior, but you need to extend it by manually invoking the carousel as described in the README.md file. It works according to the documentation so I don't see an issue there.

If your point is that it doesn't conform with the Bootstrap "data-" API philosophy - I agree. If you issue a PR I will gladly merge it in.

from bootstrap-carousel-swipe.

CybMeta avatar CybMeta commented on June 9, 2024

Uhhmmm.....now I agree with you. Thanks for the explanation.

from bootstrap-carousel-swipe.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.