format mismatch warnings

[dl8dtl]

format mismatch warnings

[stefanrueger]

The format is wrong, it should not say h, as C cannot pass a short to a function without first promoting to int (likewise unsigned). However, the printf implementation should also know that C passes an int, so should silently ignore the format (which it probably does).

[dl8dtl]

I am no longer so sure about that statement (and even reading the C standard doesn't make it better :).

I'd say, let's drop the h modifiers, and change all (unsigned short) typecasts when passing arguments (in the lines before those complained about above) into (unsigned) typecasts.

Do you want me to prepare a PR?

[stefanrueger]

The format is wrong, it should not say h

The utility of %h[dxu] is to convert the int/unsigned argument (automatically promoted!) to short or unsigned short before printing. In most of above cases the h isn't needed as the argument already is pretty small. The following

#include <stdio.h>
int main() {
  printf("%04hd\n", 32768*17);
}

prints -32768 owing to the argument 0x88000 being converted to short 0x8000 and then, being a negative short printed so.