Comments (8)
@ButterscotchV Thanks for noting this. I've removed "Fixes #86" from the PR and commit message so that it won't close this issue if merged.
from cache-apt-pkgs-action.
I have also encountered this issue.
Running a workflow with debug logging enabled shows that the if condition for the upload-logs step always gets evaluated to a truthy string:
##[debug]Evaluating condition for step: 'run'
##[debug]Evaluating: (success() && format('{0} == "true"', inputs.debug))
##[debug]Evaluating And:
##[debug]..Evaluating success:
##[debug]..=> true
##[debug]..Evaluating format:
##[debug]....Evaluating String:
##[debug]....=> '{0} == "true"'
##[debug]....Evaluating Index:
##[debug]......Evaluating inputs:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'debug'
##[debug]....=> 'false'
##[debug]..=> 'false == "true"'
##[debug]=> 'false == "true"'
##[debug]Expanded: (true && 'false == "true"')
##[debug]Result: 'false == "true"'
##[debug]Starting: run
I've opened a PR to fix this: #87.
from cache-apt-pkgs-action.
Just gonna note quickly that #87 does not fully resolve this issue, as the first bullet will still be incorrect since inputs.version
is resolved to true
, which is odd.
from cache-apt-pkgs-action.
Sorry for the lag. Going through backlog right now and issued a new patch v1.2.3 that rolled up the PR here. Also working through a fix for #84; ongoing work is in the dev
branch.
@ButterscotchV could you clarify what you mean about inputs.version
evaluating to true
? AFAIK, version bumps have forced cache updates properly.
from cache-apt-pkgs-action.
I'm really not sure if it's a problem, but just at quick observation from the GitHub Actions output, it looks like it's resolving to true
rather than 1.0
as I'd expect as I've defined in my workflow file.
Hopefully these screenshots can show what I mean a little better, you can see I have the version set to 1.0
but the output is true
. I'm assuming it may be getting evaluated as a boolean, as if 1.0
were to be evaluated as a boolean, you would see true
as the output.
Here are screenshots presented in the same order as I listed them in the issue:
From the GitHub Actions run:
From the actions.yml file in this repo:
From the GitHub Actions workflow file on my repo:
from cache-apt-pkgs-action.
The first screenshot is for the post_cache_action.sh
and the other is for pre_cache_action.sh
. 😸
from cache-apt-pkgs-action.
Ah yep, you're quite right on that, it looks like it's working fine if I'm actually looking at the right one lol. Everything looks all good now, thank you!
from cache-apt-pkgs-action.
No problem. 👍
from cache-apt-pkgs-action.
Related Issues (20)
- Verifying packages is slow HOT 3
- Improperly caching libnewlib-arm-none-eabi HOT 3
- `apt-cache show` fails on package that does exist (`libtk8.6`) HOT 3
- Fails to install on self-hosted runners HOT 2
- tar: Cowardly refusing to create an empty archive HOT 7
- Cache is installed on first run, not available when restored HOT 3
- Report bug issue using open source rockery HOT 1
- "Packages argument cannot be empty." even if `PACKAGES` is set. HOT 2
- Thoughts on caching `apt update`? HOT 3
- Please tag a release HOT 11
- What happened to the v1 tag? HOT 3
- apt-cache does not find packages with nektos/act HOT 6
- Exec Format Error on ARM Runner with apt_query HOT 4
- arm64 support. HOT 6
- Migrate Bash logic to Golang binary. HOT 1
- tar: u: Cannot stat: No such file or directory
- Error about apt package list being not signed HOT 2
- Package just.. missing from the list
- Failing on v1.2.4 HOT 18
- tar Cannot stat: No such file or directory HOT 28
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cache-apt-pkgs-action.