awesome_print wont work in Rails if ActiveRecord is not used

[awesome-print]

awesome_print wont work in Rails if ActiveRecord is not used

[thedanielhanke]

ok i created a new empty project and yes - you are right.

the evil is msgpack-rails which messes(d!) around with stuff like

module ActiveRecord
  module Serialization
    include ActiveModel::Serializers::Msgpack
  end
end

recent versions look fine however.

i wonder if that "change" might still help out - i guess there are many further bad written gems out there like msgpack-rails.

however, from my side this can be marked as closed. Thank you, @gerrywastaken

[thedanielhanke]

you are welcome + cheers for this gem ;)

[michaeldv]

Check out 0.2.0. You should be able to use awesome_print with Ruby scripts that use ActiveRecord outside of Rails.

[thedanielhanke]

i`d rather like to use AP without beeing forced to use ActiveRecord.

[gerrywastaken]

@thedanielhanke or @alexw668 How did you go about creating a Rails application which does not load AR?

[alexw668]

@gerrywastaken We have apps that uses no-SQL database like MongoDB or Neo4j (a graph database) that don't deal with AR.

[gerrywastaken]

@alexw668 I mean, what is the process you used to stop it from loading. As in which file did you modify and how, so I can test the issue accurately and not end up making bad assumptions about your setup.

[thedanielhanke]

@gerrywastaken sorry for this short delay.

head config/application.rb -n 10
require File.expand_path('../boot', __FILE__)

require 'rails'
%w(
  action_controller
  action_view
  action_mailer
).each do |framework|
  begin
    require "#{framework}/railtie"

was all i needed to do.

---

and ya i still miss AP :)

[thedanielhanke]

can be fixed like this:

    def cast_with_active_record(object, type)
      cast = cast_without_active_record(object, type)
      return cast if !defined?(::ActiveRecord)

      if object.is_a?(::ActiveRecord::Base)

should become

    def cast_with_active_record(object, type)
      cast = cast_without_active_record(object, type)
      return cast if !defined?(::ActiveRecord::Base)       #< -----------------

      if object.is_a?(::ActiveRecord::Base)

or even by unless (defined?(::ActiveRecord) || defined?(::ActiveRecord::Base)

[gerrywastaken]

I'm not sure how this ended up closed. I haven't yet had a chance to look into it. Thanks for the info @thedanielhanke 👍

[gerrywastaken]

Ok so the original bug was created a long time ago so tracking it back, the problem was originally here:
https://github.com/awesome-print/awesome_print/blob/0.1.3/lib/ap/mixin/rails.rb#L17

It then moved here:
https://github.com/awesome-print/awesome_print/blob/0.2.0/lib/ap/mixin/active_record.rb

This commit should have then fixed the issue reported by @alexw668:
05265cb#diff-e567c486212ebaee39cf4091c38a4d84R17

Then in this commit the AcitveRecord::Base check was swapped for an ActiveRecord check:
dfbebd4#diff-e567c486212ebaee39cf4091c38a4d84L17

Now this should not have affected @alexw668 as for him ActiveRecord isn't defined at all, so I'm unclear how is he would still be hitting the original bug.

@thedanielhanke Your bug appears to be that ActiveRecord is somehow getting defined by something (before awesome print is loaded), but it doesn't create ActiveRecord::Base.

Your fix is good, but I don't think it's the same issue as was reported here. I suspect the issue reported here was fixed quite some time ago. @alexw668 can you confirm?

[gerrywastaken]

I'm just glad your issue was solved. I think it's a good change regardless and I suspect there will be others who are affected by this issue so I'll likely merge it in.

Cheers for investigating the root cause, I really appreciate that. 👍

I suspect @alexw668 was the one who originally closed this, but can't be sure as Github isn't telling me. I'll leave this open for three more days to give @alexw668 a chance to respond.