Date and DateTime do not print correctly

[awesome-print]

Date and DateTime do not print correctly

[michaeldv]

Hi,

What is your version of Rails/ActiveSupport? What exactly doesn't print correctly? Please let me know how I could to reproduce the issue.

Michael

[0xradical]

Hi Michael, I'm using Rails 3.1.3. On my machine, with awesome_print turned on:

(main):0 > Date.new
#<Date:0x7fc6316e0ee8
    @__ca__ = {},
    @of = 0,
    @sg = 2299161,
    attr_reader :ajd = -0.5
>
(main):0 > Date.new.inspect
"Mon, 01 Jan -4712"
(main):0 > Time.new
2011-12-02 13:43:02 -0200 # greenish
(main):0 > Time.new.inspect
"2011-12-02 13:43:31 -0200"
(main):0 > ActiveSupport::TimeZone.new('Eastern Time (US & Canada)').now
Fri, 02 Dec 2011 10:39:37 EST -05:00 #greenish
(main):0 > ActiveSupport::TimeZone.new('Eastern Time (US & Canada)').now.inspect
"Fri, 02 Dec 2011 10:44:02 EST -05:00"

I made this monkey-patch and it worked as expected afterwards:

  module AwesomePrint
    module TimeClasses

      def self.included(base)
        base.send :alias_method, :cast_without_time_classes, :cast
        base.send :alias_method, :cast, :cast_with_time_classes
      end

      def cast_with_time_classes(object,type)
        cast = cast_without_time_classes(object,type)
        if object.is_a?(::Date)
          cast = :date
        end
        cast
      end

      def awesome_date(object)
        colorize(object.inspect, :time)
      end

    end
  end

  AwesomePrint::Formatter.send(:include,AwesomePrint::TimeClasses)

Hope that helped

[michaeldv]

Thanks! Looks like the latest ActiveSupport sticks in instance vars into the Date object so the date gets formatted as an object. Changing:

17: if object.is_a?(::ActiveSupport::TimeWithZone)
to
17: if object.is_a?(::ActiveSupport::TimeWithZone) || object.is_a?(::Date)

in ext/active_support.rb seems to fix it. I'm going to add a spec and make it part of 1.0.2 release.

Thanks again ;-)

Michael