Comments (3)
I think the PR checklist is already intimidating to new contributors, expanding it would make it worse (even though they just have to delete the lower part, that's still one more thing to do/understand and will discourage people).
Unfortunately Github doesn't allow multiple PR templates (e.g one for additions, one for updates, one for cleanup of old projects, etc.) It is possible for issues (when New Issue
is clicked it shows a nice list allowing you to select the template), but not for PRs. Worth noting that Gitlab and Gitea-and-likes do have this feature.
- The correct thing to do when updating or removing an entry is to just delete the placeholder/checklist. I think we should make this clearer.
See also #33 (comment) where a possible "contributor guide"/FAQ is discussed.
By the way, thank you for your help with maintenance these last days.
from awesome-selfhosted-data.
Unfortunately Github doesn't allow multiple PR templates (e.g one for additions, one for updates, one for cleanup of old projects, etc.) It is possible for issues (when
New Issue
is clicked it shows a nice list allowing you to select the template), but not for PRs. Worth noting that Gitlab and Gitea-and-likes do have this feature.
I found this out yesterday and could not believe github lacks support for multiple PR templates.
It makes plenty of sense that we do not want to add complexity to the PR process.
from awesome-selfhosted-data.
Proposed fix in #542
from awesome-selfhosted-data.
Related Issues (20)
- Add Moonlight Panel HOT 2
- Classification by power requirements HOT 5
- Add Litecart HOT 9
- Add NUTCase HOT 1
- Keepass available via WebDAV and SFTP HOT 2
- Add MyIP HOT 7
- Add Leaflet HOT 1
- Add Geoman HOT 1
- Add Readeck
- Laravel Simple Password Manager appears twice HOT 1
- Update license type of immich software
- Add Technitium DNS Server HOT 2
- Add SOFTWARE_NAME
- Add Wavelog HOT 4
- Add dokploy HOT 2
- Duplicate entries: motion.tools, OpenSlides, ZOT OCI Registry and Tiny File Manager HOT 1
- Add Part-DB
- Add Dagu HOT 1
- Add Pelican Panel HOT 2
- Add OpenTTD HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from awesome-selfhosted-data.