Giter Site home page Giter Site logo

Comments (3)

nodiscc avatar nodiscc commented on July 20, 2024 2

I think the PR checklist is already intimidating to new contributors, expanding it would make it worse (even though they just have to delete the lower part, that's still one more thing to do/understand and will discourage people).

Unfortunately Github doesn't allow multiple PR templates (e.g one for additions, one for updates, one for cleanup of old projects, etc.) It is possible for issues (when New Issue is clicked it shows a nice list allowing you to select the template), but not for PRs. Worth noting that Gitlab and Gitea-and-likes do have this feature.

  • The correct thing to do when updating or removing an entry is to just delete the placeholder/checklist. I think we should make this clearer.

See also #33 (comment) where a possible "contributor guide"/FAQ is discussed.

By the way, thank you for your help with maintenance these last days.

from awesome-selfhosted-data.

ryangurn avatar ryangurn commented on July 20, 2024

Unfortunately Github doesn't allow multiple PR templates (e.g one for additions, one for updates, one for cleanup of old projects, etc.) It is possible for issues (when New Issue is clicked it shows a nice list allowing you to select the template), but not for PRs. Worth noting that Gitlab and Gitea-and-likes do have this feature.

I found this out yesterday and could not believe github lacks support for multiple PR templates.

It makes plenty of sense that we do not want to add complexity to the PR process.

from awesome-selfhosted-data.

nodiscc avatar nodiscc commented on July 20, 2024

Proposed fix in #542

from awesome-selfhosted-data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.