Giter Site home page Giter Site logo

Comments (7)

pippinsplugins avatar pippinsplugins commented on July 30, 2024 1

OR we could go ahead and merge the PR that @brashrebel did but not deploy it anywhere. If a site is still using the theme, they can grab the changes here.

from edd-digital-store.

pippinsplugins avatar pippinsplugins commented on July 30, 2024

Digital Store is no longer maintained so I propose wontfix and close here.

from edd-digital-store.

SeanTOSCD avatar SeanTOSCD commented on July 30, 2024

@pippinsplugins Tested. The PR works for me. I'm good with merging and letting it be.

@brashrebel Can you go ahead and version bump as well? Might as well continue to maintain that.

from edd-digital-store.

brashrebel avatar brashrebel commented on July 30, 2024

Just pushed that. My bad. I didn't realize this theme wasn't getting updates. I was just about to open another issue too. I think I will anyway just to keep a record but won't pursue a patch.

from edd-digital-store.

pippinsplugins avatar pippinsplugins commented on July 30, 2024

We may end up needing to revert the core change. There's now been reports of this problem in 4-5 different themes. Basically anyone that modified edd.css doesn't see the new icon :(

from edd-digital-store.

SeanTOSCD avatar SeanTOSCD commented on July 30, 2024

I'll dig into this today. Definitely not specific to Digital Store but I have to figure out why it's happening. I don't wanna revert if we don't have to.

from edd-digital-store.

SeanTOSCD avatar SeanTOSCD commented on July 30, 2024

Fixed in EDD, so this won't happen in Digital Store anymore. But the changes made to Digital Store are still fine considering they update some other relevant CSS. Closing this and merging the PR. Thanks @brashrebel!

from edd-digital-store.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.