Comments (7)
OR we could go ahead and merge the PR that @brashrebel did but not deploy it anywhere. If a site is still using the theme, they can grab the changes here.
from edd-digital-store.
Digital Store is no longer maintained so I propose wontfix
and close here.
from edd-digital-store.
@pippinsplugins Tested. The PR works for me. I'm good with merging and letting it be.
@brashrebel Can you go ahead and version bump as well? Might as well continue to maintain that.
from edd-digital-store.
Just pushed that. My bad. I didn't realize this theme wasn't getting updates. I was just about to open another issue too. I think I will anyway just to keep a record but won't pursue a patch.
from edd-digital-store.
We may end up needing to revert the core change. There's now been reports of this problem in 4-5 different themes. Basically anyone that modified edd.css doesn't see the new icon :(
from edd-digital-store.
I'll dig into this today. Definitely not specific to Digital Store but I have to figure out why it's happening. I don't wanna revert if we don't have to.
from edd-digital-store.
Fixed in EDD, so this won't happen in Digital Store anymore. But the changes made to Digital Store are still fine considering they update some other relevant CSS. Closing this and merging the PR. Thanks @brashrebel!
from edd-digital-store.
Related Issues (20)
- Shouldn't be theme name translatable? HOT 4
- Incorrect name for registered image sizes being called HOT 1
- Theme fatal errors if EDD not present HOT 3
- Theme options HOT 1
- Page excerpts show in single view HOT 1
- Selectivizr HOT 5
- Entry meta text shows when there are no category assignments HOT 4
- Display issue when only 1 comment on a post
- MediaElementJS Styling Conflicts HOT 2
- Fatal error if EDD is not active
- Invalid argument passed to wp_editor()
- Add EDD downloads CSS for 2.5 update HOT 4
- improve checkout styles HOT 1
- update the updater
- adjust theme details
- add styles for Recurring Payments 2.4
- adjust JS syntax for WP update HOT 1
- Removing spans from legends in EDD causes UI change. HOT 1
- Purchase link dropdown sits out of place if text is unusual length
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edd-digital-store.