Comments (2)
I'm okay in general with modifying git-managed files, as long as the file that is checked in to git doesn't contain references that are invalid. In the ECS agent, we manage this by having the file set the git sha to UNKNOWN
when checked in, but set to the real sha during builds.
The other way that people typically do things like this with Go + git is by setting the value of a variable at build time with a linker option (something like go build -ldflags "-X version.GitSha=${SHA}"
). I'm not terribly opposed to this pattern either, but if we want to switch here I'd prefer that we switch in our other projects too (consistency is important).
from amazon-ecs-init.
Fixed by #91.
from amazon-ecs-init.
Related Issues (20)
- Add staticcheck tool to ecs-init (same as agent) HOT 1
- Containers with multiple listening ports in 'host' networking unable to send traffic to other local ports HOT 2
- Installation of ecs volume plugin on RHEL HOT 3
- ECS Agent update issue HOT 1
- iptables rule isn't removed on service restart after changing ECS_ALLOW_OFFHOST_INTROSPECTION_ACCESS from false to true HOT 1
- Setting ECS_ALLOW_OFFHOST_INTROSPECTION_ACCESS=true doesn't appear to work on Amazon Linux 1 HOT 1
- ECS cluster registers new task every time While uploading large file in aws ecs through loadbalancer with 503 gateway error HOT 7
- ECS service doesn't always run at boot time due to systemd breaking service ordering cycles HOT 4
- Migrate from dep to go modules for dependency management HOT 1
- Configurable ecs-agent image version HOT 8
- Support overriding ecs agent certificate with host certificate for generic rpm package
- 1.53.0 not availalbe as rpm HOT 1
- Running "make deb" or "make generic-rpm" does not package amazon-ecs-volume-plugin HOT 2
- Offhost ECS Agent Container Introspection is permanently enabled when primary NIC is not called eth0 HOT 4
- ecs anywhere install script: unnecessary requirement on dirmngr HOT 1
- post-stop seems to require dockerd socket access HOT 11
- Cannot build RPM package on CentOS 7.9.2009 HOT 2
- amazon-ecs-volume-plugin.service is missing in SLES 15 SP2 amazon-ecs-init 1.53 version HOT 2
- [Proposal] Integrate ECS Init into ECS Agent & deprecate standalone ECS Init repository HOT 3
- VolumeDriver.Create: encountered error(s) in creating the volume HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amazon-ecs-init.