Giter Site home page Giter Site logo

Comments (2)

samuelkarp avatar samuelkarp commented on May 20, 2024

I'm okay in general with modifying git-managed files, as long as the file that is checked in to git doesn't contain references that are invalid. In the ECS agent, we manage this by having the file set the git sha to UNKNOWN when checked in, but set to the real sha during builds.

The other way that people typically do things like this with Go + git is by setting the value of a variable at build time with a linker option (something like go build -ldflags "-X version.GitSha=${SHA}"). I'm not terribly opposed to this pattern either, but if we want to switch here I'd prefer that we switch in our other projects too (consistency is important).

from amazon-ecs-init.

samuelkarp avatar samuelkarp commented on May 20, 2024

Fixed by #91.

from amazon-ecs-init.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.