Comments (4)
nckturner
commented on August 14, 2024
1
Should have a PR for the simple case soon.
from aws-app-mesh-controller-for-k8s.
nckturner
commented on August 14, 2024
In the situation that something was leaked by the controller and the mesh custom resource is deleted, do we want to discover everything in the mesh via API and delete it that way? Or just fail to delete the mesh when leaks happen?
from aws-app-mesh-controller-for-k8s.
stefanprodan
commented on August 14, 2024
I would delete the mesh objects and the mesh itself from AppMesh only. If the operator would delete Kubernetes objects that are not explicitly deleted by the client (kubectl or another operator) this would break many things. For example a GitOps operator like Flux, JenkinsX, etc will recreate the virtual nodes and you'll end up into an infinite delete/create loop.
from aws-app-mesh-controller-for-k8s.
nckturner
commented on August 14, 2024
Yeah that makes sense, because they aren't actually owned by the mesh (they weren't created due to the mesh object being created).
from aws-app-mesh-controller-for-k8s.
Related Issues (20)
- Support configuring envoy LISTENER_DRAIN_WAIT_TIME_S environment variable
- Setting appmesh.k8s.aws/sidecarEnv: "ENVOY_LOG_LEVEL=debug" does not change the pod env var HOT 3
- Documentation: Health Checks failing after tls.mode=STRICT
- Second Listener for Virtual Nodes HOT 2
- PostStart hook fails if `envoyAdminAccessPort` is set HOT 3
- GatewayRoute Selector Inconsistent Behavior
- Virtual Node DNS service discovery is not working as expected HOT 2
- Outdated Changelog and release list
- Support for GatewayRoute target port HOT 1
- Unable to create routes for VirtualRouter with multiple listener HOT 4
- GatewayRoute Admission Webhook not in keeping with AWS API/UI: match prefix does not need to end in '/' HOT 1
- After modyifing the virtualrouter/virtualnode k8s manifest file it not update changes inPlace HOT 11
- GrpcRouteMatch port match error despite defining it HOT 6
- can't inject env var with a comma in it's value HOT 4
- 🚨 appmesh-envoy:v1.27.0.0-prod does not run HOT 2
- Override APPMESH_EGRESS_IGNORED_PORTS in injected proxyInit container HOT 4
- Does the cloudmap namespace have to match the k8s namespace? HOT 10
- No Init or Sidecar containers injected HOT 2
- cert-manager api deprecated HOT 1
- Missing documentation for that EKS VPC Endpoint is required for private cluster
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-app-mesh-controller-for-k8s.