Giter Site home page Giter Site logo

Comments (5)

nckturner avatar nckturner commented on August 14, 2024

Oops! Looks like we broke it here when we moved to a template file. We need an install step that works in the github docs as well as the AWS docs. Something like this could work:

curl https://raw.githubusercontent.com/aws/aws-app-mesh-controller-for-k8s/v0.1.2/examples/color.yaml.template | sed -e 's/${APP_NAMESPACE}/appmesh-demo/g' -e 's/${MESH_NAME}/color-mesh/g' ... | kubectl apply -f -

from aws-app-mesh-controller-for-k8s.

fmedery avatar fmedery commented on August 14, 2024

@nckturner I was about to propose a PR but there is also this variable :

${COLOR_GATEWAY_IMAGE}

I am curious to know why we don't host these example images on the AWS dockerhub registry ?

from aws-app-mesh-controller-for-k8s.

kiranmeduri avatar kiranmeduri commented on August 14, 2024

we don't have a good release process to keep those images up-to-date. I vote for moving this example to aws-app-mesh-examples project and inline it here https://github.com/aws/aws-app-mesh-examples/tree/master/walkthroughs/eks. That way users can try different examples with little additional effort after basic git clone.

from aws-app-mesh-controller-for-k8s.

nckturner avatar nckturner commented on August 14, 2024

That's fine with me, but we'll need to duplicate it there, then update the AWS docs, then remove it from here.

from aws-app-mesh-controller-for-k8s.

kiranmeduri avatar kiranmeduri commented on August 14, 2024

@nckturner can this be resolved, given that the recommended installation is via helm-charts and then follow aws-app-mesh-examples.

from aws-app-mesh-controller-for-k8s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.