v0.1.2: unable to create Virtual nodes or Virtual routers

[aws]

v0.1.2: unable to create Virtual nodes or Virtual routers

[nckturner]

The latest release was modified to run 5 goroutines instead of 1, so it could be possible you're seeing contention between them? Are the objects not being created successfully at all (ignoring the error messages)? I see Created virtual node in your logs.

[stefanprodan]

@nckturner I had the same problem with Flagger, this is how I solved it https://github.com/weaveworks/flagger/blob/master/pkg/canary/status.go#L70

[nckturner]

Thanks @stefanprodan, we should give that a try.

[fmedery]

The latest release was modified to run 5 goroutines instead of 1, so it could be possible you're seeing contention between them? Are the objects not being created successfully at all (ignoring the error messages)? I see Created virtual node in your logs.

@nckturner No the objects were not created.

@stefanprodan tx for pointing out the workaround.

[kiranmeduri]

Yes, I have seen the contention and corresponding error messages. @stefanprodan your fix should help in this case, but I believe controller code needs some TLC.

@fmedery this contention happens when the status is being updated, however the resources should have been created.

[kiranmeduri]

There is a non-backward compatible change in CRD where virtual-router now is required and need to provide a listener. This is the reason for

E0908 19:07:49.287511       1 controller.go:443] error syncing 'appmesh-demo/colorteller.appmesh-demo': error creating virtual router: InvalidParameter: 1 validation error(s) found.

I am working on a fix to allow old behavior that allowed virtual-service without virtual-router spec.

[nckturner]

Can this be closed? @kiranmeduri