OnChange is called when no changes occurred

[aws]

OnChange is called when no changes occurred

[KenHundley]

Ok, this should be corrected with this PR. I tested a similar scenario and the change event was only firing when an actual deviation was detected.

[KenHundley]

The executing code has no way to know beforehand if the values have changed in the Parameter Store, so it must query them to get their current state even if nothing has changed. This OnChange event is that trigger.

[timje]

aws-dotnet-extensions-configuration/src/Amazon.Extensions.Configuration.SystemsManager/SystemsManagerConfigurationProvider.cs

Line 112 in 4e19059

Data = ProcessParameters(parameters, path);

Could you compare before/after and see if "Data" changed? Then only call OnReload if it changed?

[KenHundley]

ok, got it. So the issue you are having is because the OnReload method is getting called. I can look at adding a before and after comparison here and only execute the OnReload if the Dictionaries are different.

Can I ask what issue you are getting from the current code? I'd like to understand exactly what's happening currently so that I can ensure the issue is resolved after a code change.

[timje]

Great thanks! I'm subscribing to IOptionsMonitor.OnChange and clearing some cached data when this occurs (because the cached data was populated based on the parameters). But this doesn't work as expected, since the OnChange is fired every "reloadAfter" seconds.