UBSAN triggers on `is_available` getting passed an incorrect function type

[justhecuke]

UBSAN triggers on `is_available` getting passed an incorrect function type

[justhecuke]

Found more

hash_table.c:68:12: runtime error: call to function aws_byte_cursor_eq through pointer to incorrect function type 'bool (*)(const void *, const void *)'
ref_count.c:29:9: runtime error: call to function s_s2n_ctx_destroy through pointer to incorrect function type 'void (*)(void *)'

[maddeleine]

Thanks for this issue, we'll take a look.

[jmayclin]

Hi @justhecuke! What platform did you use to produce these warnings?

I have ubsan running on Clang 15 with ARM, seem to get a different set of warning than the ones you encountered.

[justhecuke]

Hey, I'm not sure how to answer "what platform", but it's Clang 17 in Bazel. We have a bit of a frankenstein system and I'm building this as part of our own build, which is where I find the sanitizer issues.

The code I'm working with is from a1.11.185 aws-sdk-cpp archive and it's a bit confusing how to translate that aws-sdk-cpp tag into a tag/commit over here.

EDIT: I think it's 4654fecb05cd5aacbda262654eb95a3876183698 here which is v1.3.54?

[justhecuke]

In any case, even if I'm wrong on the specifics, it's somewhat clear that UBSAN can help in CI or some manual runs every now and then.