Comments (7)
Agreed I think the repo should be automatically created if using CodeCommit as a source, we have the account Id and we know the repo name so this makes sense. I think this would be best as the default if using CodeCommit, I cannot see a scenario when you would not want the repo created. Should we bother with the 'create-repo' key?
from aws-deployment-framework.
It might be that users want to create the repo them selfs using CF and including event lambdas and stuff. Also for backwards compatibility but for that we could check if the repo exists with an api call.
from aws-deployment-framework.
Ok, I like the idea. Maybe we should make it the default then, and it can be opt out of with:
create-repo: false
from aws-deployment-framework.
+1
We currently use a seperate ADF managed pipeline that just churns out CodeCommit repositories including some IAM Roles that prevents pushing directly to master. Recently AWS CodeCommit allows you to provide initial content (e.g. README.md and .gitignore templates) by pointing to a zip file on an s3 bucket.
Would be great if this can be made possible through ADF as well. We could add another parameter pointing to the zip file:
pipelines:
- name: my-sample-app
create-repo: true
initial-repo-content: arn::s3:mybucket/initialrepocontent.zip
```
from aws-deployment-framework.
Something else, shouldn't the create-repo parameter fit better in the params section like so:
pipelines:
- name: my-sample-app
type: cc-cloudformation
params:
- create-repo: true
- initial-repo-content: arn::s3:mybucket/initialrepocontent.zip
from aws-deployment-framework.
After reading this thread I actually think you either want to have ADF create your repos or you dont. I dont really see that you want it to manage some of them.
So I actually think a global autogenerate-code-repositories: true | false
is what we would want.
But I really do like the idea of adding initial commit through a configurable endpoint.
from aws-deployment-framework.
Perhaps, I don’t think the deployment map supports any global config parameters at the moment.
I do feel you want to be able to have different initial commit for repos created with ADF so that should not be a global param.
from aws-deployment-framework.
Related Issues (20)
- [Bug]: DeleteDefaultVPC fails with OptInRequired HOT 2
- [Feat]: New release HOT 2
- [Bug]: Parameter "deployment_account_id" into deployment account's parameter store HOT 2
- [Feat]: Terraform variables per region
- [Bug]: Account Based Terraform variables do not work
- [Feat]: Improve auto-create-repository behaviour within Deployment Map Definition HOT 1
- [Feat]: Add Python isort and black linters. HOT 2
- [Feat]: Enhanced Targetting via Tags HOT 1
- AWS CodeBuild error: 'list' object has no attribute 'get'
- [Bug]: generate_params script type errors are not clear what's the issue
- [Bug]: <Error during ADF deployment cfn_custom_resource> HOT 4
- [Chore]: Upgrade GitHub CodeQL Action v2 to v3 HOT 1
- [Feat]: enable pylint on samples dir and optionally on test files
- ADF new version release HOT 4
- [Feat]: deploy multiple SCPs to a single OU or account HOT 6
- is it possibile to create another aws account using ADF HOT 2
- [Bug]: Account creation is broken since the release of lambda runtime 3.9v51 HOT 2
- [Feat]: Alerting for when AccountFileProcessorFunction fails
- StateMachine PipelineDeletionStateMachine is in failed HOT 1
- adf-bootstrap code pipeline fails in management account
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-deployment-framework.