Giter Site home page Giter Site logo

Comments (7)

bundyfx avatar bundyfx commented on June 28, 2024

Agreed I think the repo should be automatically created if using CodeCommit as a source, we have the account Id and we know the repo name so this makes sense. I think this would be best as the default if using CodeCommit, I cannot see a scenario when you would not want the repo created. Should we bother with the 'create-repo' key?

from aws-deployment-framework.

triha74 avatar triha74 commented on June 28, 2024

It might be that users want to create the repo them selfs using CF and including event lambdas and stuff. Also for backwards compatibility but for that we could check if the repo exists with an api call.

from aws-deployment-framework.

bundyfx avatar bundyfx commented on June 28, 2024

Ok, I like the idea. Maybe we should make it the default then, and it can be opt out of with:

create-repo: false

from aws-deployment-framework.

thiezn avatar thiezn commented on June 28, 2024

+1

We currently use a seperate ADF managed pipeline that just churns out CodeCommit repositories including some IAM Roles that prevents pushing directly to master. Recently AWS CodeCommit allows you to provide initial content (e.g. README.md and .gitignore templates) by pointing to a zip file on an s3 bucket.

Would be great if this can be made possible through ADF as well. We could add another parameter pointing to the zip file:

pipelines:
  - name: my-sample-app
    create-repo: true
    initial-repo-content: arn::s3:mybucket/initialrepocontent.zip
```

from aws-deployment-framework.

thiezn avatar thiezn commented on June 28, 2024

Something else, shouldn't the create-repo parameter fit better in the params section like so:

pipelines:
  - name: my-sample-app
    type: cc-cloudformation
    params:
     - create-repo: true
     - initial-repo-content: arn::s3:mybucket/initialrepocontent.zip

from aws-deployment-framework.

triha74 avatar triha74 commented on June 28, 2024

After reading this thread I actually think you either want to have ADF create your repos or you dont. I dont really see that you want it to manage some of them.

So I actually think a global autogenerate-code-repositories: true | false is what we would want.

But I really do like the idea of adding initial commit through a configurable endpoint.

from aws-deployment-framework.

thiezn avatar thiezn commented on June 28, 2024

Perhaps, I don’t think the deployment map supports any global config parameters at the moment.

I do feel you want to be able to have different initial commit for repos created with ADF so that should not be a global param.

from aws-deployment-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.