Comments (8)
We're still encountering this issue on the latest build (2.6.24)
Here is some additional information we've encountered while testing.
It seems to only happen after a different query with the cache policy (fetchIgnoringCacheData) has already completed.
Our use-case is that when a user-logs in, a query is performed (fetchIgnoringCacheData) that loads in data that the user will need. This is successful. Once that query is completed, we do a different query fetching some additional information the user needs. For this second query we use the cache policy (returnCacheDataElseFetch). This second query is the one that encounters the issue. No network request is made, and a value from the cache is returned with nil.
We have verified there are no cached values for this query when nil is returned from the cache.
We have verified that if we do not do the first query, then the second one works as expected.
from aws-mobile-appsync-sdk-ios.
We created two tests inside ApolloTests/FetchQueryTests that I believe reproduce the issue. The first test, testSICSecondQueryAlone(), runs successfully, and is essentially a duplicate of testFetchIgnoringCacheData() but uses a StarshipQuery and a .returnCacheDataElseFetch cache policy. The second test, testSICFetchIgnoringCacheData(), first performs the fetch from testFetchIgnoringCacheData(), then in the completion handler of the first query performs the fetch from testSICSecondQueryAlone(). In this case the StarshipQuery returns nil.
func testSICSecondQueryAlone() {
let query2 = StarshipQuery()
let initialRecords: RecordSet = [:]
withCache(initialRecords: initialRecords) { cache in
let store = ApolloStore(cache: cache)
let networkTransport2 = MockNetworkTransport(body: [
"data": [
"starship": [
"name": "ASDF",
"__typename": "Starship"
]
]
])
let client2 = ApolloClient(networkTransport: networkTransport2, store: store)
let expectation = self.expectation(description: "Fetching query")
client2.fetch(query: query2, cachePolicy: .returnCacheDataElseFetch) { (result, error) in
defer { expectation.fulfill() }
guard let result = result else { XCTFail("No query result"); return
}
guard let name = result.data?.starship?.name else {
XCTFail("No query result")
return
}
XCTAssertEqual(name, "ASDF")
}
self.waitForExpectations(timeout: 5, handler: nil)
}
}
func testSICFetchIgnoringCacheData() throws {
let query = HeroNameQuery()
let initialRecords: RecordSet = [:]
withCache(initialRecords: initialRecords) { cache in
let store = ApolloStore(cache: cache)
let networkTransport = MockNetworkTransport(body: [
"data": [
"hero": [
"name": "Luke Skywalker",
"__typename": "Human"
]
]
])
let client = ApolloClient(networkTransport: networkTransport, store: store)
let expectation = self.expectation(description: "Fetching query")
let expectation2 = self.expectation(description: "Fetching query2")
client.fetch(query: query, cachePolicy: .fetchIgnoringCacheData) { (result, error) in
defer { expectation.fulfill() }
guard let result = result else { XCTFail("No query result"); return }
XCTAssertEqual(result.data?.hero?.name, "Luke Skywalker")
let query2 = StarshipQuery()
let networkTransport2 = MockNetworkTransport(body: [
"data": [
"starship": [
"name": "ASDF",
"__typename": "Starship"
]
]
])
let client2 = ApolloClient(networkTransport: networkTransport2, store: store)
client2.fetch(query: query2, cachePolicy: .returnCacheDataElseFetch)
{ (result, error) in
defer { expectation2.fulfill() }
guard let result = result else { XCTFail("No query result"); return }
guard let name = result.data?.starship?.name else {
XCTFail("No query result")
return
}
XCTAssertEqual(name, "ASDF")
}
}
self.waitForExpectations(timeout: 5, handler: nil)
}
}
from aws-mobile-appsync-sdk-ios.
Additionally, we believe the code change that is causing the issue is in commit c417b11 in GraphQLExecutor line 214. In previous versions of app sync that do not show the bug, the second query executes the throw JSONDecodingError.missingValue, while since this change, the second query executes self.complete(...)
from aws-mobile-appsync-sdk-ios.
Thank you @peteslavich!
@rohandubal @palpatim would you like us to submit a pull-request with this test breaking? @peteslavich has narrowed down what looks like the likely cause, but we don't yet fully understand the reason for that change so we are hesitant to change it ourselves.
from aws-mobile-appsync-sdk-ios.
Hi @joelmbell,
Sorry for the delayed response on this. I have a test that demonstrates this behavior and am investigating the proper way to handle this. I'll update this thread as soon as I have more info.
from aws-mobile-appsync-sdk-ios.
I was able to make some headway on this during investigations into updating the cache on optimistic updates. PR #182 should fix this, assuming that the approach works as I expect. (I'm investigating whether it is in fact the right approach; I need to validate the assumptions I'm making testing for "empty result values" in that PR.)
from aws-mobile-appsync-sdk-ios.
This fix is released in 2.10.1. Please let us know if you continue to see issues.
from aws-mobile-appsync-sdk-ios.
This issue has been automatically closed because of inactivity. Please open a new issue if are still encountering problems.
from aws-mobile-appsync-sdk-ios.
Related Issues (20)
- Crash: AWSAppSyncClient.sync HOT 5
- Removing pods from source control HOT 2
- AWSMobileClient Crash when app starts HOT 3
- Completion Handler on AWSAppSyncClient.perform called more than once. HOT 1
- Enabling retry for custom scenarios HOT 1
- Update SQLite dependency to match Amplify.DataStore's SQLite version
- Make public constructor for GraphQLError HOT 2
- SPM dependency conflict with Amplify library HOT 6
- Using AWSAppSync with Amplify DataStore HOT 5
- App crashes: AWSAppSync $s10AWSAppSync36AWSCognitoUserPoolsAuthProviderAsyncPAAE09getLatestF5TokenSSyF HOT 1
- SPM dependency resolution failure using aws-mobile-appsync-sdk-ios 3.6.2 and amplify-swift 2.6.0 HOT 2
- AWS subscriptions - subscribe function is not thread safe and causes crashes HOT 1
- Version incompability with other amplify packages HOT 2
- Unknow TCP connection process keep running even when all subscriptions are unsubscribed HOT 1
- How to avoid duplicate mutations when the app is backgrounded/quit before the mutation is finished? HOT 1
- AppSync retry mechanism HOT 3
- Built app with Xcode 15.2 crashes after AppSyncClient subscribe on iOS 16.3.1 version or lower HOT 4
- For iOS App, We are using this SDK, We are getting ITMS-91053: Missing API declaration recently because PrivacyInfo needs to be included for 3rd party SDK. HOT 9
- Crash on APIKeyBasedConnectionPool HOT 12
- Xcode 16 build error "Missing argument label 'value'" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-mobile-appsync-sdk-ios.