Comments (6)
@bitinn this is a great idea. I will see about tweaking the build to provide an option that excludes the polyfill.
from axios.
@mzabriskie this still causes problems in our project which imports axios indirectly, i.e. we import another library which imports axios. In our case we're building our project using webpack which is eventually importing axios, and naturally we haven't set up the es6-promise
external you have in your config.
A better approach might be to check if a native Promise implementation exists at runtime, because es6-promise
's polyfill method will just override anything that already exists in the global namespace.
from axios.
E.g.
var es6Promise = require('es6-promise');
if (!global.Promise) {
es6Promise.polyfill();
}
Although I'd question whether it's valuable for axios to be supplying the polyfill at all. It seems like it's useful exclusively for when the library's loaded in isolation - which won't happen in any more complex project with its own build system.
In that case it might be better to include a bootstrapping file only for your dist
webpack entry, and do the polyfilling there.
Anyone that imports axios from source can be reasonably expected to have polyfilled their environment to include a Promise implementation.
from axios.
@wmadden the next release will remove the es6-promise
dependency all together. This will require you to either have an environment that natively offers Promise
, or polyfill it yourself. Will that work for your use case?
from axios.
Great, thanks very much @mzabriskie!
from axios.
For webpack users looking for a way to polyfill Promises. Expose loader does the job nicely without requiring a boostrapped entry: 'expose?Promise!bluebird'
var CommonsChunkPlugin = require('webpack/lib/optimize/CommonsChunkPlugin');
module.exports = {
entry: {
'appBundle': './appEntry.js',
vendors: [
'expose?Promise!bluebird',
'axios',
],
},
plugins: [
new CommonsChunkPlugin('vendors', './commonVendors.js'),
],
module: {
loaders: [
{
test: /\.jsx?$/,
exclude: /(node_modules)/,
loader: 'babel',
},
],
},
};
from axios.
Related Issues (20)
- Form data key of "x-amz-security-token" changes from string key to object {x: { amz: {security: { token: <value> } } } }
- What is the correct version guide of Axios? HOT 2
- SSRF Vulnerability Arising from Axios URL Parsing HOT 3
- Why is the headers attribute of InternalAxiosRequestConfig mandatory?
- Security Vulnerability from follow-redirects HOT 1
- axios V0.28.0 Uncaught ReferenceError: req is not defined at AbortSignal.onCanceled HOT 7
- Network Error in React Native HOT 5
- Axios lib gets detected as a trojan HOT 3
- Can't find variable: axios error thrown on older browser (since v.1.6.8) HOT 1
- Invalid package attestation - 1.6.8 HOT 4
- Axios calculating wrong Content-Length HOT 2
- Information Exposure due to the handling of the Proxy-Authorization header across hosts HOT 1
- The interface has a return value, but the axios report response is undefined
- http req with proxy + ca doesn't work HOT 1
- Axios 500 Error Problem HOT 3
- Security: Axios sends HTTPS data in cleartext to a proxy (regression)
- Proxy environment variables ignored HOT 1
- Axios Unable to Handle "204 No Content" Responses
- Request body converted the params into string type causing wrong response as compare to network request using fetch (React native) HOT 1
- Using HTTP proxy for HTTPS address does not start a HTTP Connection HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from axios.