Giter Site home page Giter Site logo

Comments (6)

mzabriskie avatar mzabriskie commented on March 29, 2024

@bitinn this is a great idea. I will see about tweaking the build to provide an option that excludes the polyfill.

from axios.

wmadden avatar wmadden commented on March 29, 2024

@mzabriskie this still causes problems in our project which imports axios indirectly, i.e. we import another library which imports axios. In our case we're building our project using webpack which is eventually importing axios, and naturally we haven't set up the es6-promise external you have in your config.

A better approach might be to check if a native Promise implementation exists at runtime, because es6-promise's polyfill method will just override anything that already exists in the global namespace.

from axios.

wmadden avatar wmadden commented on March 29, 2024

E.g.

var es6Promise = require('es6-promise');
if (!global.Promise) {
  es6Promise.polyfill();
}

Although I'd question whether it's valuable for axios to be supplying the polyfill at all. It seems like it's useful exclusively for when the library's loaded in isolation - which won't happen in any more complex project with its own build system.

In that case it might be better to include a bootstrapping file only for your dist webpack entry, and do the polyfilling there.

Anyone that imports axios from source can be reasonably expected to have polyfilled their environment to include a Promise implementation.

from axios.

mzabriskie avatar mzabriskie commented on March 29, 2024

@wmadden the next release will remove the es6-promise dependency all together. This will require you to either have an environment that natively offers Promise, or polyfill it yourself. Will that work for your use case?

from axios.

wmadden avatar wmadden commented on March 29, 2024

Great, thanks very much @mzabriskie!

from axios.

gbrassey avatar gbrassey commented on March 29, 2024

For webpack users looking for a way to polyfill Promises. Expose loader does the job nicely without requiring a boostrapped entry: 'expose?Promise!bluebird'

var CommonsChunkPlugin = require('webpack/lib/optimize/CommonsChunkPlugin');

module.exports = {
  entry: {
    'appBundle': './appEntry.js',
    vendors: [
      'expose?Promise!bluebird',
      'axios',
    ],
  },
  plugins: [
    new CommonsChunkPlugin('vendors', './commonVendors.js'),
  ],
  module: {
    loaders: [
      {
        test: /\.jsx?$/,
        exclude: /(node_modules)/,
        loader: 'babel',
      },
    ],
  },
};

from axios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.