Comments (5)
@vkurchatkin Would you mind providing example code so that I know how to reproduce this?
from axios.
Here it is
var axios = require('axios');
var http = require('http');
var assert = require('assert');
var str = Array(100000).join('ΠΆ');
http.createServer(function(req, res) {
res.setHeader('Content-Type', 'text/html; charset=UTF-8');
res.end(str);
}).listen(4444, function() {
axios.get('http://localhost:4444/').then(function(response) {
process.nextTick(function() {
assert(response.data === str);
});
});
});
I'm not sure that this test is 100% reliable (or that a 100% reliable test of this exists at all)
from axios.
Thanks. I'll give this a look.
from axios.
Here is a quick fix:
diff --git a/lib/adapters/http.js b/lib/adapters/http.js
index 8a6fbf6..81da7ac 100644
--- a/lib/adapters/http.js
+++ b/lib/adapters/http.js
@@ -52,15 +52,15 @@ module.exports = function httpAdapter(resolve, reject, config) {
// Create the request
var transport = parsed.protocol === 'https:' ? https : http;
var req = transport.request(options, function (res) {
- var responseText = '';
+ var responseBuffer = [];
res.on('data', function (chunk) {
- responseText += chunk;
+ responseBuffer.push(chunk);
});
res.on('end', function () {
var response = {
data: transformData(
- responseText,
+ Buffer.concat(responseBuffer).toString('utf8'),
res.headers,
config.transformResponse
),
@@ -83,4 +83,4 @@ module.exports = function httpAdapter(resolve, reject, config) {
// Send the request
req.end(data);
-};
\ No newline at end of file
+};
from axios.
@vkurchatkin thank you for your diff. I will apply this and write some tests around it.
from axios.
Related Issues (20)
- vite5+vue3+ts Sending request error SyntaxError: The requested module '/node_modules/.vite/deps/axios.js?v=bc297318' does not provide an export named 'AxiosInstance' HOT 1
- Issue CVEs for vulnerabilities fixed by #6167 and #6163 HOT 1
- How to set localAddress when sending HTTP requests? HOT 2
- API call happening twice, but called once! HOT 3
- RefferenceError: Axios is not defined. HOT 2
- Security vulnerability HOT 2
- postForm's form-data serialization breaks for Blob in Node.js
- Axios stream aborts early during 204 response from prism cli.
- I am getting a error involving CancelToken.js...
- TypeError: Converting circular structure to JSON
- React native Android NETWORK ERROR HOT 1
- Issue with downloading files larger than a few mbs on Chrome specifically HOT 4
- please expose the formDataToStream for public use
- 100% Upload progress on dev mode only.
- XSRF-TOKEN logic should utilize cookie domain instead of current page domain HOT 1
- Question: Rollup configuration with ESM
- Formidable arbitrary file upload vulnerability HOT 1
- ERR_FR_TOO_MANY_REDIRECTS using Axios but not in browser, using curl or python-requests HOT 2
- Cannot read properties of undefined (reading 'prototype') at node_modules/follow-redirects/index.js HOT 1
- Using RawAxiosRequestHeaders cause compiler error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from axios.