Giter Site home page Giter Site logo

Comments (4)

MrHedmad avatar MrHedmad commented on June 19, 2024 1

I've added the rustls-tls feature to reqwest and the binary size is identical. Still need to try it out but I guess that solves my issue! I'll leave closing to you; maybe you wish to still include the option to change runners.

Thank you for the ultra-fast reply!

from cargo-dist.

Gankra avatar Gankra commented on June 19, 2024

So we do hardcode to the oldest possible runner we can find specifically to link against the oldest possible libraries. In particular we want to link against the oldest possible glibc, so that the linux-gnu binaries are as portable as possible (for instance, iirc github codespaces defaults to running on 20.04, so binaries built on 22.04 fail to run there 😭).

Also just checking: you do for reals want to be linking openssl, yeah? Most rust projects try to avoid this, opting to statically link rust-tls: https://github.com/axodotdev/gazenot/blob/ef900eca9c9c8309290b303faebae85cafebf9c5/Cargo.toml#L31-L35

from cargo-dist.

Gankra avatar Gankra commented on June 19, 2024

(I'm not opposed to having settings to bump up the runners, just first checking that it actually solves your problem)

from cargo-dist.

MrHedmad avatar MrHedmad commented on June 19, 2024

I'm a Rust beginner so I'm still not familiar with all of this linking issues. But if I can avoid relying on opensll of course it would be best. The only issues I got when including openssl (see here) is that the binary size baloons. But I had no idea that reqwest can use something else entirely, as you show. I'll try it and check binary sizes. But I think that probably will fix the issue.

Still, maybe an obscure option somewhere to set the runners might still be useful to someone, at some point!

from cargo-dist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.