Occasionally crash on Windows

[gpetrov]

Occasionally crash on Windows

[implausible]

Context-awareness is pretty unstable in electron right now. I think we need to adjust this package to add appropriate shutdown behavior now that the team has released the API to do so.

[carlos-labrador]

@julianmesa-gitkraken ,
FYI
I could not reproduce the issue in a new project, that means the package is working properly.
Thank you so much for your fast response and time.

[carlos-labrador]

I'm going to test it in a empty project to see if this happen, if so I will provide those details. thank you so much.

[implausible]

Are you doing a page navigation?

[gpetrov]

Well it might be - a lot of the files are loaded in webviews.

Why would navigation cause this?

[gpetrov]

Any progress here?

we got very frequent electron crashes now on various file operations....

We can't reliably use NSFW and have to switch to something else, if not solved soon, on Windows due to this problem.

A recent crash is:

FATAL ERROR: Error::Error napi_create_reference
 1: 00007FF66E2B03F6 node::Buffer::New+45638
 2: 00007FF66E2B0600 node::OnFatalError+464
 3: 00007FF66E2B0429 node::Buffer::New+45689
 4: 00007FF66E7CED6D napi_fatal_error+173
 5: 00007FFF3C231897 Napi::Error::Fatal+23 [c:\develop\xxxxx\node_modules\node-addon-api\napi-inl.h]:L2305
 6: 00007FFF3C23180C Napi::Error::New+364 [c:\develop\xxxxx\node_modules\node-addon-api\napi-inl.h]:L2293
 7: 00007FFF3C236011 <lambda_02a4ead201235c7fc21c358d1f0d324b>::operator()+2257 [c:\develop\xxxxx\node_modules\nsfw\src\nsfw.cpp]:L305
 8: 00007FFF3C239017 std::_Func_impl_no_alloc<<lambda_4d778e92cb460459ca5943375ac023e3>,void,Napi::Env,Napi::Function>::_Do_call+39 [c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.16.27023\include\functional]:L16707566
 9: 00007FFF3C232C91 Napi::ThreadSafeFunction::CallJS+129 [c:\develop\xxxx\node_modules\node-addon-api\napi-inl.h]:L5205
10: 00007FF66E7D1D4F napi_ref_threadsafe_function+4623
11: 00007FF66E2CB9EC uv_run+492
12: 00007FF66E2989DB node::EmitAsyncDestroy+200955
13: 00007FF66E298DE6 node::EmitAsyncDestroy+201990
14: 00007FF66E264EDC node::FreeEnvironment+108
15: 00007FF66CD614C5 v8::MemorySpan<unsigned char const >::MemorySpan<unsigned char const >+148565
16: 00007FF66FE9B644 Cr_z_crc32+583684
17: 00007FF66EF47BD6 uv_stream_set_blocking+1246854
18: 00007FF66EB539C5 Cr_z_uncompress+458853
19: 00007FF66E5C3E1C GetHandleVerifier+2777164
20: 00007FF66EB60ABD Cr_z_uncompress+512349
21: 00007FF66FFAA6C4 Cr_z_crc32+1693828
22: 00007FF6700CED03 Cr_z_crc32+2891459
23: 00007FF66F9022F2 v8::EmbedderHeapTracer::RegisterEmbedderReference+60578
24: 00006F97000F33FC
crash reason: xxxx process crashed.
Renderer process crashed - see https://www.electronjs.org/docs/tutorial/application-debugging for potential debugging information.

[carlos-labrador]

same here ,is there any update about this issue ?

[julianmesa-gitkraken]

@carlos-labrador are you using version 2.2.3?

[carlos-labrador]

right, my version is 2.2.3

[julianmesa-gitkraken]

@carlos-labrador can you provide steps or example to reproduce the issue?