Comments (10)
I guess you’d also have to update in npm-shrinkwrap.json
, too. (As a side note, why are the dev dependencies shrinkwrapped?)
from metalsmith-concat.
Installing with --no-shrinkwrap
is the safest, quickest way around this. Otherwise, yes, this library is currently broken.
from metalsmith-concat.
thanks for the heads-up, should now be fixed, reopen if needed!
from metalsmith-concat.
@aymericbeaumet Thanks!
I know it’s slightly out-of-scope for this issue, but can I ask why all the dev dependencies are shrinkwrapped? There are only 4 dependencies for a consumer of the library, but the shrinkwrap file lists 267 dependencies, which is a lot more to pull down when someone tries to npm install
an app that uses this.
from metalsmith-concat.
i don't think the dev dependencies are being included in the shrinkwrap
$ npm shrinkwrap
npm WARN shrinkwrap Excluding devDependency: [email protected] { minimatch: '3.0.0' }
npm WARN shrinkwrap Excluding devDependency: [email protected] { minimatch: '3.0.0' }
npm WARN shrinkwrap Excluding devDependency: [email protected] { minimatch: '3.0.0' }
npm WARN shrinkwrap Excluding devDependency: [email protected] { minimatch: '3.0.0' }
npm WARN shrinkwrap Excluding devDependency: [email protected] { minimatch: '3.0.0' }
wrote npm-shrinkwrap.json
the file lists 267 dependencies because it includes all the dependencies (recursively, down to the last one)
$ npm shrinkwrap --dev
$ git diff | wc -l
548
from metalsmith-concat.
Well, just looking at: https://github.com/aymericbeaumet/metalsmith-concat/blob/master/npm-shrinkwrap.json
And if you look into minimatch
, the only non-dev dependency, it only has one dependency: https://github.com/isaacs/minimatch/blob/v3.0.0/package.json
Which is brace-expansion
, which has two dependencies: https://github.com/juliangruber/brace-expansion/blob/v1.1.3/package.json
Which are balanced-match
and concat-map
, each of which have no dependecies:
https://github.com/juliangruber/balanced-match/blob/v0.3.0/package.json
https://github.com/substack/node-concat-map/blob/0.0.1/package.json
…so there should only be 4 modules in npm-shrinkwrap.json
if it doesn’t include any dev dependencies.
There are clearly a lot more things than that listed in the file.
from metalsmith-concat.
npm-remote-ls is also a helpful tool for this kind of stuff:
npm-remote-ls [email protected] --development false
from metalsmith-concat.
Also, I’d venture a guess that you’re tripping over the same problem I was when I tried to do this in my PR—it’s easiest if you blow away your shrinkwrap file before regenerating; it can screw up the generation of a new one. That’s why I had a second commit that modified the shrinkwrap file again: f0ce590
from metalsmith-concat.
i see, npm install --production && npm shrinkwrap
solved the issue. thanks for noticing!
from metalsmith-concat.
No problem :)
from metalsmith-concat.
Related Issues (20)
- metalsmith-concat fails to install with npm 2.3.0 HOT 3
- Getting an error when src directory contains same name of file build should concat to HOT 1
- Concatenate outside of directory
- Multiple output files HOT 1
- support sourcemaps when concatenating HOT 1
- Files deleted when paired with live reload. HOT 1
- Files deleted when paired with live reload. HOT 2
- Make overwrite check optional
- Allow Concatination of files outside src HOT 10
- Add sort option HOT 2
- Simplify paths HOT 2
- writing files with strings vs Buffers? HOT 1
- Notify in documentation the base path HOT 1
- Empty dist file HOT 4
- Lumens HOT 2
- High Dependency Vulnerability: minimatch HOT 1
- v6.0.3 [email protected] postinstall Fails HOT 2
- Action required: Greenkeeper could not be activated 🚨
- Path Separator is Mixed on Windows HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metalsmith-concat.