Giter Site home page Giter Site logo

Comments (6)

zigdon avatar zigdon commented on August 22, 2024

I believe the server will send back a ERR_NICKNAMEINUSE (or one of the
other 43x messages) if we can't get it?
On 1404207268896, Finn Ellis [email protected] wrote:

We can tell the server what nick we want, but unless I'm missing something
we can't tell whether we've gotten it.


Reply to this email directly or view it on GitHub
#12.

from kitnirc.

ayust avatar ayust commented on August 22, 2024

The main question is, what should happen if we don't get the nick we want?

I had left implementing such verification to users of the library for now because I don't think there's a clear single answer to that question. In some cases, it means needing to do some kind of authentication with services; in other cases, it means needing to ghost an old incarnation or otherwise recover the nick, and in yet other cases the right thing to do might be to just exit, or accept the name as given.

Thoughts?

from kitnirc.

zigdon avatar zigdon commented on August 22, 2024

Could you not just raise an exception, and let the clients deal with it
that way? Right now I think kitn just ignores the error, meaning the
clients have to write more code just to see it.

On Tue Jul 01 2014 at 7:19:22 PM, Amber Yust [email protected]
wrote:

The main question is, what should happen if we don't get the nick we want?

I had left implementing such verification to users of the library for now
because I don't think there's a clear single answer to that question. In
some cases, it means needing to do some kind of authentication with
services; in other cases, it means needing to ghost an old incarnation or
otherwise recover the nick, and in yet other cases the right thing to do
might be to just exit, or accept the name as given.

Thoughts?


Reply to this email directly or view it on GitHub
#12 (comment).

from kitnirc.

relsqui avatar relsqui commented on August 22, 2024

Yeah; I don't need you to do something about it, but it would be helpful if you told me so I can. Honestly, it would be sufficient just to have a nick attribute on the client which promises to be the actual nick, not just the one I asked for, and then I can test against it if I care.

from kitnirc.

ayust avatar ayust commented on August 22, 2024

@relsqui - that should be the case already (your_client.user.nick); while it's initialized to the nick you request, it's updated from the hostmask provided by the server in its WELCOME message. If that's not the case, then I might need to add some more logic.

from kitnirc.

relsqui avatar relsqui commented on August 22, 2024

Ah, okay, I didn't notice that. I haven't hit a case that would expose if that doesn't work yet, but if I do and it doesn't I'll let you know.

from kitnirc.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.