Comments (6)
I believe the server will send back a ERR_NICKNAMEINUSE (or one of the
other 43x messages) if we can't get it?
On 1404207268896, Finn Ellis [email protected] wrote:
We can tell the server what nick we want, but unless I'm missing something
we can't tell whether we've gotten it.—
Reply to this email directly or view it on GitHub
#12.
from kitnirc.
The main question is, what should happen if we don't get the nick we want?
I had left implementing such verification to users of the library for now because I don't think there's a clear single answer to that question. In some cases, it means needing to do some kind of authentication with services; in other cases, it means needing to ghost an old incarnation or otherwise recover the nick, and in yet other cases the right thing to do might be to just exit, or accept the name as given.
Thoughts?
from kitnirc.
Could you not just raise an exception, and let the clients deal with it
that way? Right now I think kitn just ignores the error, meaning the
clients have to write more code just to see it.
On Tue Jul 01 2014 at 7:19:22 PM, Amber Yust [email protected]
wrote:
The main question is, what should happen if we don't get the nick we want?
I had left implementing such verification to users of the library for now
because I don't think there's a clear single answer to that question. In
some cases, it means needing to do some kind of authentication with
services; in other cases, it means needing to ghost an old incarnation or
otherwise recover the nick, and in yet other cases the right thing to do
might be to just exit, or accept the name as given.Thoughts?
—
Reply to this email directly or view it on GitHub
#12 (comment).
from kitnirc.
Yeah; I don't need you to do something about it, but it would be helpful if you told me so I can. Honestly, it would be sufficient just to have a nick attribute on the client which promises to be the actual nick, not just the one I asked for, and then I can test against it if I care.
from kitnirc.
@relsqui - that should be the case already (your_client.user.nick
); while it's initialized to the nick you request, it's updated from the hostmask provided by the server in its WELCOME
message. If that's not the case, then I might need to add some more logic.
from kitnirc.
Ah, okay, I didn't notice that. I haven't hit a case that would expose if that doesn't work yet, but if I do and it doesn't I'll let you know.
from kitnirc.
Related Issues (14)
- Report reason for failure to load module. HOT 2
- Bot believes it's not in channel when trying to set a mode. HOT 14
- IRC styling/colors. HOT 3
- Handle disconnection. Reconnect? HOT 1
- Problems related to treating channel names as if they are case-sensitive, or something like that HOT 4
- Add toggleable highlight to client.reply
- Add topic(channel, topic) command to client.py to change topic
- Authentication module HOT 3
- Add !help/!commands command to contrib/commands.py
- Bot never joins channel, ends up with broken pipe. HOT 6
- Where should community Modules go? HOT 1
- password not working with znc HOT 10
- Change log level while running. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kitnirc.