Comments (7)
I tried implementing a potenty bordure once (using SVG masks and stroke-dasharray) and the results were not great, especially in the corners. My conclusion was that this would need defining a different path for each shield shape and for each variation (so way too much work).
from armoria.
These are just technical limitations
from armoria.
Does that preclude the chevrons and other ordinaries from having those aswell?
I'd also add, is it worth cotising being a separate parameter? Those can be a different tincture to the ordinary itself, and can often be a different varient too (eg. An embattled chevron, with normal cotise, and vice versa).
from armoria.
It does not, but it's hard to do and require a lot of time to implement. It's an open source project, so you can implement this feature on your own and make it available for others.
from armoria.
Here is an example of issues with bordure when trying to do it the "simple way":
![](https://private-user-images.githubusercontent.com/21015346/348686539-a44d935a-3166-4972-84ba-5500f1f1755f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0ODYwMTgsIm5iZiI6MTcyNDQ4NTcxOCwicGF0aCI6Ii8yMTAxNTM0Ni8zNDg2ODY1MzktYTQ0ZDkzNWEtMzE2Ni00OTcyLTg0YmEtNTUwMGYxZjE3NTVmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDA3NDgzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFmNzI1ZDNlODI2ZWViZjU2OWI1MTQwYTkyY2IzMGQ3MzU1MWJlYWU2ZGU3ODNmZjE3OGVmYzI2Y2E0NWI3MjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.SCH-t51WNRIaB6GtqKJKLtsdT1EQ5YVWGP-ysBqHzq4)
Similarly, this might look weird for chevrons at the angle points. For anyone wanting to try it, the following can be done:
- Define chevron as a lined ordinary instead of straight in dataModel.js
- Add a new chevronLined entry in the
templates
object of templates.js, that should be similar to the chevron entry but with additional fancy lines with proper rotation and translation (look at other lined ordinaries to see how it is done)
from armoria.
I actually don't think that looks too bad. Granted, it's not perfect, but I've honestly seen real rendering that look far worse than this.
I've not looked at the code, so don't know how the rendering on each edge works, but you might be able to make a few simple tweaks, like offsets to the pattern and the start and end , or the scale on eaxh edge so they arent uniform, to tidy it up a bit. Honestly I think that looks fine though, especially considering we don't have any options right now to do it.
Similarly, this might look weird for chevrons at the angle points. For anyone wanting to try it, the following can be done:
I might give it a play when I get a free moment. Could be fun.
from armoria.
simple tweaks
These simple tweaks and not simple at all
from armoria.
Related Issues (20)
- Issues with some of the new charges HOT 4
- Integrate with AI to auto-generate blazons HOT 2
- Use generative AI to generate explanation of elements HOT 2
- Generate mottos HOT 1
- Migrate to all-in-one SvelteKit HOT 9
- Support Marshalling HOT 3
- Loading issue with Semi/Conventional HOT 1
- SVG conversion on Edge HOT 5
- Translate app into Russian
- Change tincture color from editor HOT 1
- Add a text box showing the symbolism and history of a selected charge HOT 3
- Use the Github integration feature of Crowdin to allow offline use? HOT 7
- Combine charges HOT 2
- Simplified charges upload for well-known icon collections
- Add text elements HOT 1
- Semy HOT 3
- Color group can have 0 total chance HOT 1
- Scale issue HOT 2
- Sizing Issue HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from armoria.