Performance of reimplemented functions?

[azjezz]

Performance of reimplemented functions?

[azjezz]

this is expected, if you are using PHP >= 7.4, i recommend including vendor/azjezz/psl/src/preload.php in your preload file, or using it as a preload file if you don't have anything else to preload, which should give better performance as functions will be cached after the first run ( assuming you are using php-fpm or fastcgi ), if it's a CLI script, i cannot recommand anything that would improve performance here.

[azjezz]

Hm, after https://phpsandbox.io/n/wispy-leaf-75nn-pnldg, i noticed that the unqiue function is causing the performance issue here, not count ( which has almost the same performance ).

I think there's a way to fix this.

in https://github.com/azjezz/psl/blob/1.6.x/src/Psl/Dict/unique.php#L17, we should add

if (is_array($iterable)) {
  return array_unique($iterable);
}

can you please send a PR and verify that performance has been improved in this case specifically?

P.S: any pull request to improve performance is welcome, even if it adds complexity.

Just tried the fix and now the performance is perfectly comparable.

PR incoming.

Thanks!