Comments (11)
Are you up for a PR?
I'm on it
from psl.
You right, first
, second
and rest
sounds more logic, I see it now
from psl.
Hm, i think we can allowing extra arguments to Type\union and Type\intersection ( i prefer if these two provide the same API ).
This will also prevent a BC break, in v2.0 we can drop $right and $left and make both union and intersection accept variadic arguments.
from psl.
🤔 Hmm, I kept in my that UnionType
has left and right branches, therefore function union()
takes two arguments to be honest with users.
I was thinking about suggestion to define extra function to prevent boilerplate when we need define union type with a lot of cases.
But, If you think it is alright to expand already existed function - it is fair enough for me
from psl.
we can have function union(TypeInterface $right, TypeInterface $left, TypeInterface ...$other)
, UnionType
is an internal class, there's no reason to design the public API to match it.
from psl.
Looks great for me.
from psl.
Are you up for a PR?
from psl.
By the way, why you want to make union
and intersection
completely variadic (in v2.0)?
union(string())
- doesn't make sense for me
from psl.
union(string()) - doesn't make sense for me
it doesn't to me too, but that's solvable via Psl\invariant(Iter\count($types) >= 2, 'at least 2 types are required to create a union.');
from psl.
union(string()) - doesn't make sense for me
it doesn't to me too, but that's solvable via
Psl\invariant(Iter\count($types) >= 2, 'at least 2 types are required to create a union.');
Do you prefer runtime exception instead of statically analysed issue?
from psl.
the reason is i don't like $right, $left, $others
, maybe we could just rename them to something more appropriate...
WDYT about $first, $second, ...$rest
? ( renaming arguments is not BC break, we can do it now )
from psl.
Related Issues (20)
- [Type] add `nonnull` type
- [Type] add `string_range` and `int_range` types.
- Undeprecate `positive_int` HOT 2
- base64 url safe encoding HOT 1
- Return value of `Psl\Str\trim()` must be of the type string, null returned HOT 6
- `CoercionException::withValue()` called but not throwed. Is this dead code? HOT 1
- Improve error messages for shape and vec -like types
- Improve Dict\merge HOT 1
- Make PSL PHPStan compliant
- Add an `option()` type to `Psl\Type` to coerce to a `Psl\Option\Option` HOT 3
- Split this package is multiple sub-packages HOT 2
- [Bug] Vec\range handles ints which don't roundtrip through floats wrong
- intersection + shapes unexpected behaviour (possible bug?) HOT 4
- Type\implements_interface HOT 3
- Corece an `array` out of an `stdClass`? HOT 3
- [RFC] Change `ResultInterface<T>` to `ResultInterface<T, E>` HOT 5
- chore: rename all enum cases to use PascalCase
- Improvement converted json type HOT 5
- Is nonnull helpful in any way? HOT 1
- PHPStan extension unable to report optional positive-int
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psl.