Giter Site home page Giter Site logo

Comments (13)

fredysierra avatar fredysierra commented on September 24, 2024 1

@saragluna we know that adding this entity-type property is not hard. Our problem is the scale of this. We have many different services on our platform, and our clients can define their own services. For us and them, this would be a huge inconvenience. For now, we are looking into options to hack this. (adding the property dynamically ). However, it would be really important for us to have a property that defines the entity-type by default.

from azure-sdk-for-java.

joshfree avatar joshfree commented on September 24, 2024

@saragluna could you please help route @fredysierra's issue

from azure-sdk-for-java.

Netyyyy avatar Netyyyy commented on September 24, 2024

Hi @fredysierra , thanks for reaching out, we will take a look

from azure-sdk-for-java.

Netyyyy avatar Netyyyy commented on September 24, 2024

Hi @fredysierra , sorry for the inconvenience, spring.cloud.azure.servicebus.producer.entity-type and spring.cloud.azure.servicebus.consumer.entity-type doesn't work for bindings, please use spring.cloud.stream.servicebus.bindings.<binding-name>.consumer.entity-type or spring.cloud.stream.servicebus.bindings.<binding-name>.producer.entity-type instead, see Spring Cloud Stream support for more info.

If you use ARM to connect, it's necessary to configure each consumer or producer clearly, it's by design for provision resources and here is a sample. Or you use other way such connection-string, only need to configure
entity-type for producer.

from azure-sdk-for-java.

github-actions avatar github-actions commented on September 24, 2024

Hi @fredysierra. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

from azure-sdk-for-java.

fredysierra avatar fredysierra commented on September 24, 2024

Hi @fredysierra , sorry for the inconvenience, spring.cloud.azure.servicebus.producer.entity-type and spring.cloud.azure.servicebus.consumer.entity-type doesn't work for bindings, please use spring.cloud.stream.servicebus.bindings.<binding-name>.consumer.entity-type or spring.cloud.stream.servicebus.bindings.<binding-name>.producer.entity-type instead, see Spring Cloud Stream support for more info.

If you use ARM to connect, it's necessary to configure each consumer or producer clearly, it's by design for provision resources and here is a sample. Or you use other way such connection-string, only need to configure entity-type for producer.

Thank you so much for your answer. Considering this is a breaking change, it is frustrating that it was introduced in a minor upgrade version. As I mentioned to you, specifying entity-type per binder is a big inconvenience as we have a large number of producers and consumers in our product and our clients can define their own.

from azure-sdk-for-java.

Netyyyy avatar Netyyyy commented on September 24, 2024

Hi @fredysierra , it's an enhancement because in the past, it won't check if the entity-type is null

and add this code to make sure user can configure the entity-type correctly.
As for the second question, @saragluna should we add a new feature for configuring one entity-type and all consumers and producers can use it?

from azure-sdk-for-java.

saragluna avatar saragluna commented on September 24, 2024

Sorry for the inconvenience, @fredysierra. Could you help share your configuration file? Setting on the producer/consumer is actually an intuitive way.

from azure-sdk-for-java.

saragluna avatar saragluna commented on September 24, 2024

@fredysierra may I ask whether you are using the ServiceBus binder to provison your queue or topic?

from azure-sdk-for-java.

fredysierra avatar fredysierra commented on September 24, 2024

yes @saragluna We do use the binder to provision those.

from azure-sdk-for-java.

saragluna avatar saragluna commented on September 24, 2024

@fredysierra we'll try to fix this.

from azure-sdk-for-java.

saragluna avatar saragluna commented on September 24, 2024

Will fix it by enabling the default value by setting "spring.cloud.stream.servicebus.default.producer|consumer.xxx", which will be picked up as the default value of "spring.cloud.stream.servicebus.bindings.<channel-name>.producer|consumer.xxx".

from azure-sdk-for-java.

Netyyyy avatar Netyyyy commented on September 24, 2024

Fixed in Spring Cloud Azure 5.11/4.17

from azure-sdk-for-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.