[BUG] azure-storage-blob library with azure-core-http-okhttp client prevents application from termination for 60 seconds.

[if-of]

[BUG] azure-storage-blob library with azure-core-http-okhttp client prevents application from termination for 60 seconds.

[alzimmermsft]

Thank you for filing this question @if-of.

Did some investigation, this appears to be the default behavior of OkHttp's Dispatcher class, which in turn by default we don't modify when OkHttp is being used leaving that configuration to the application to handle.

Looking at Dispatcher it uses a ThreadFactory that creates non-daemon threads for the ExecutorService backing the Dispatcher (https://github.com/square/okhttp/blob/master/okhttp/src/main/kotlin/okhttp3/Dispatcher.kt#L103, https://github.com/square/okhttp/blob/master/okhttp/src/main/kotlin/okhttp3/internal/-UtilJvm.kt#L65).

The good news, our OkHttp HttpClient builder allows for configuration of the Dispatcher being used. So, a simple work around could be supplying your own Dispatcher that doesn't use daemon threads, therefore prevents the Dispatcher from preventing JVM shutdown while the threads time out in the ExecutorService.

https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core/azure-core-http-okhttp/src/main/java/com/azure/core/http/okhttp/OkHttpAsyncHttpClientBuilder.java#L298

[if-of]

Thank you, @alzimmermsft. Your workaround effectively solved my issue, eliminating the 60-second wait time.

P.S: It's quite unfortunate that this isn't the default behavior. However, considering the simplicity of the fix, it's not much of an inconvenience.

[github-actions]

Hi @if-of. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

[github-actions]

Hi @if-of, since you haven’t asked that we /unresolve the issue, we’ll close this out. If you believe further discussion is needed, please add a comment /unresolve to reopen the issue.