Suspicious commented-out code

[azure]

Suspicious commented-out code

[quasilyte]

In the std/debug package there is also something scary:

func dbgGetUserValue(state *lua.State) int {
	fmt.Println("debug.getuservalue")
	state.Debug(true)
	// if state.TypeAt(1) != lua.UserDataType {
	// 	state.Push(nil)
	// } else {
	// 	state.GetUserValue(1)
	// }
	return 1
}

Commented-out code should be either:

• Removed
• Uncommented if it's needed
• Or at least add a comment why it's commented-out and how it can be fixed

[quasilyte]

Found another thing:

golua/std/base/base.go

Lines 184 to 188 in 4ee7f28

	// error message is on top of the stack
	state.Push(nil)
	state.Push(err.Error())
	// state.Insert(-2) // put before error message
	return 2 // return nil plus error message

It's unclear for me whether // state.Insert(-2) // put before error message is needed or not.
But maybe maintainers know better. :)