Giter Site home page Giter Site logo

Comments (3)

akx avatar akx commented on July 17, 2024

Ah, apparently

client = ComputeManagementClient(...)
client.config.keep_alive = True

makes the client instance not close the underlying session. Whether or that's safe, I have no idea...

from msrest-for-python.

lmazuel avatar lmazuel commented on July 17, 2024

Hi @akx
Currently, you have two ways to achieve this:

  • Use the client as a context manager (with ComputeManagementClient(**parameters) as client)
  • Use the flag you found (and the close() method when done)

It was not activated in early SDK, and I didn't activated it by default with current SDK, because that's a breaking change. This code will leak socket connection for example:

for el in myloop():
    client = ComputeClientManagement(**parameters)
    client.virtual_machines.list(**el)

Next major version of client will introduce async, and I decided to make the pool enabled by default with a disclaimer in the ChangeLog.

Hope this clarify :). Thanks!

https://github.com/Azure/msrest-for-python#2018-04-18-version-0428

from msrest-for-python.

lmazuel avatar lmazuel commented on July 17, 2024

Was commited part of Autorest for Python 4.0.63 as the default behavior: enabled pool per client. This will be shipped at the same time as async support in the next couples of month. Being, if the SDK supports async, it means the connection pool is activated by default.

from msrest-for-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.