Giter Site home page Giter Site logo

When deploying management resources, Security Center resources are not being deployed about terraform-azurerm-caf-enterprise-scale HOT 3 CLOSED

azure avatar azure commented on July 26, 2024 2
When deploying management resources, Security Center resources are not being deployed

from terraform-azurerm-caf-enterprise-scale.

Comments (3)

krowlandson avatar krowlandson commented on July 26, 2024

I'm just trying to reproduce this behaviour but don't seem to be able to. I'm not sure whether this is linked to the way you had your providers configured (ref. #102) but when I run the configuration changes you provided for configure_management_resources, I get the following outcome when updating security_center.enabled from false to true.

Terraform will perform the following actions:

  # module.enterprise_scale.azurerm_policy_assignment.enterprise_scale["/providers/Microsoft.Management/managementGroups/sn/providers/Microsoft.Authorization/policyAssignments/Deploy-ASC-Defender"] will be updated in-place
  ~ resource "azurerm_policy_assignment" "enterprise_scale" {
      ~ enforcement_mode     = false -> true
        id                   = "/providers/Microsoft.Management/managementGroups/sn/providers/Microsoft.Authorization/policyAssignments/Deploy-ASC-Defender"
        name                 = "Deploy-ASC-Defender"
        # (8 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

As you can see, this setting is toggling the enforcement_mode on the Deploy-ASC-Defender Policy Assignment.

As an FYI, the other settings within this config block are adjusting the parameter values sent to this Policy Assignment to control the Azure Defender pricing tier settings.

If you are still seeing no change when updating this setting, please let me know and we can try to work out what else might be causing this.

from terraform-azurerm-caf-enterprise-scale.

calexandre avatar calexandre commented on July 26, 2024

I figured it out... 🤦‍♂️
We have an archetype_exclusion_root.json where we explicitly disabled all the ASC policy assignments, which of course, led to this case of Security Center not being deployed...

We thought that even with the excluded policies, the ASC would still be deployed... But I guess that from an ES perspective, it does not make sense to deploy ASC if we don't have the required policy assignment.

I tested the plan without the exclusion, and the result was as expected :)

For reference, this is our archetype_exclusion_root.json:

{
  "exclude_es_root": {
    "policy_assignments": [
      "Deploy-ASC-Monitoring",
      "Deploy-ASC-Defender"
    ],
    "policy_definitions": [],
    "policy_set_definitions": [],
    "role_definitions": [],
    "archetype_config": {
      "parameters": {},
      "access_control": {}
    }
  }
}

You can close this :)

from terraform-azurerm-caf-enterprise-scale.

krowlandson avatar krowlandson commented on July 26, 2024

OK, great thank you. Yes, for ES we are very reliant on having those policies in place in order to configure and monitor compliance these settings 😄

from terraform-azurerm-caf-enterprise-scale.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.