Giter Site home page Giter Site logo

Comments (5)

matt-FFFFFF avatar matt-FFFFFF commented on July 27, 2024

Hi I think this is the wrong repo - you want https://github.com/aztfmod/terraform-azurerm-caf

from terraform-azurerm-caf-enterprise-scale.

qaiserali avatar qaiserali commented on July 27, 2024

@matt-FFFFFF We are not using https://github.com/aztfmod/terraform-azurerm-caf

We use this terraform-azurerm-caf-enterprise-scale module to deploy the management group hierarchy, including the governance, policies, and access controls. The module also deploys private DNS zones in the connectivity subscription.

The issue is that whenever we provision a private AKS cluster or enable a private endpoint for any of the CORP landing zone subscription services, we are prompted to grant Private DNS Contributor permissions on the private DNS zones in the connectivity subscriptions.

from terraform-azurerm-caf-enterprise-scale.

anwarnk avatar anwarnk commented on July 27, 2024

This what we did in our code to get round it, use a data source to the actual aks private dns zone and then add a role assignment before creating aks cluster

For example:

data "azurerm_private_dns_zone" "azmk8s" {
  name                = local.dns.azk8s_dns_zone_name
  resource_group_name = local.dns.dns_rg_name
  provider            = azurerm.connectivity
}

resource "azurerm_role_assignment" "assign_identity_private_dns_contributor" {
  scope                = data.azurerm_private_dns_zone.azmk8s.id
  role_definition_name = "Private DNS Zone Contributor"
  principal_id         = azurerm_user_assigned_identity.managed_identity.principal_id
}

from terraform-azurerm-caf-enterprise-scale.

qaiserali avatar qaiserali commented on July 27, 2024

@anwarnk
Yes, this is how we solved it as well. However, granting AKS permissions over the private DNS zones in the connectivity subscription is not a good idea.

from terraform-azurerm-caf-enterprise-scale.

matt-FFFFFF avatar matt-FFFFFF commented on July 27, 2024

fixed by #919

from terraform-azurerm-caf-enterprise-scale.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.