[Bug] Auth Redirect failure in ADAL on iOS

[Deloyuri]

[Bug] Auth Redirect failure in ADAL on iOS

[jmprieur]

This is an issue happening on ADAL.NET. I transferred it to the ADAL.NET repo.
@bgavrilMS @trwalke @jennyf19 @pmaytak : do we have a way of trying if MSAL.NET is also affected?

[Deloyuri]

Can you please send me link to the new issue?

…

Sent from my iPhone On Apr 20, 2021, at 3:50 AM, Jean-Marc Prieur ***@***.***> wrote:  This is an ADAL.NET issue. I transferred it to the ADAL.NET repo. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://secure-web.cisco.com/1DXdgkOMjqB5sGX1XRVCjxVK0I5E96Iz3tubNySa-U7o6Fs5AhNL5B2SeEC6mmc9ppxCy0TzCVLIxJ4Tqm8U-t5R88Lb3pnxgBtm54u-EEMAHqW0M8tU-KP-RmRNb_OgTGQK_Q8OWQUKrDZ6vU1TUd-_UFqd8lZdUqT324xNch-GurFMVwufciChoN_DMBbAL9XpSGdnXxW2Q38__Y-KeAHMx8dD-S6t7vnYgHrzNYWj05WUWSABIiyjqRrjEENBnGDdeLkTPf7FuhsNouBih-RiS9QXv7y_DQ99woUcjsWxMMawMv97UBQrLMCzeex1HEYmhHMcsBjxO1gv8aTFqJhW5fPwdA_dQ8CCweQEsuWEZZpS1HlsQsMW_W9pTW6zjz0TJhQ3dThDa_uI4tooNyGDQyYFIJf3Z8xgLNbYaQwtIrVc2FdqtENreGpZ99iNqHwsCXAhoaQd-ysdpeOrjdXp1isMaJ7fD2ruNstq0BIbXucJuVbwqjpVzB_Ipi68k4XUELGStG28I1nrehrUDYQ/https%3A%2F%2Fgithub.com%2FAzureAD%2Fazure-activedirectory-library-for-dotnet%2Fissues%2F1726%23issuecomment-823102326>, or unsubscribe<https://secure-web.cisco.com/1z1KkoubCyxwEw5pd4PQoJssp6owQAmfD3y7nGWOWn4oXYdwGIy0FV1oc6HdKMERdLw5Exjc9x8pHvtB1DNz9DBjYQUibwmu3LfozYz9DrUC89l5YBTopIHbYQfm4ieSbTY32sLQSebKaFS-qNx1CBP7U3kbPPP2TlXNpqOE1qE3NZRqicTqkcuZtIqGgyj0hXTbUGrHZpKnU3fIvdhdb0cxD92y_RLh2xwkyXHs7le7EF6qSiH0HnQtaakGElR0zAPJwgdjkJZhdzc7UVOpyXMbdk0opk7Ws_wi5ZAIr7LFEOor5C-5UA6f-cJX4hVOiWhkp9KCiaDqyW43u82eDOnfLBLUAChS1ImeDoTnpAfUz4nBX1c3XWLPA7EsbGiNQ0Nj2yB-j31kKhrdEy4Spqrj4GLXOmgcYuq36HG0KhQbAKvlV2UPokK_XgMH7vkCwYWkL4OIcUGq9NR_f49RtpEHzWIr-wtV14X4Et9IJt4_alY1IjOaqgSrUpqyRvOBzJbAEkXvYGbgzZcC4m8Q_Vg/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHOW4CDH2WQJMOGFAOVPDVTTJU56NANCNFSM43HWM2NA>. This message (including any attachments) contains confidential information intended for a specific individual and purpose, and is protected by law. If you are not the intended recipient, you should delete this message and any disclosure, copying, or distribution of this message, or the taking of any action based on it, by you is strictly prohibited. Deloitte refers to a Deloitte member firm, one of its related entities, or Deloitte Touche Tohmatsu Limited ("DTTL"). Each Deloitte member firm is a separate legal entity and a member of DTTL. DTTL does not provide services to clients. Please see www.deloitte.com/about to learn more. v.E.1

[jmprieur]

Which new issue, @Deloyuri : this is the same (just transferred from one repo to another)

[jennyf19]

@Deloyuri have you considered moving to MSAL.NET?

[Deloyuri]

Absolutely – we are a huge organization with many apps. Most, have been transitioned. We were under impression that we have another year to go for the remaining handful. Best, Yuri Livshitz

…

-- Please consider the environment before printing. From: jennyf19 ***@***.***> Reply-To: AzureAD/azure-activedirectory-library-for-dotnet ***@***.***> Date: Tuesday, April 20, 2021 at 10:21 AM To: AzureAD/azure-activedirectory-library-for-dotnet ***@***.***> Cc: "Livshitz, Yuri" ***@***.***>, Mention ***@***.***> Subject: [EXT] Re: [AzureAD/azure-activedirectory-library-for-dotnet] [Bug] Auth Redirect failure in ADAL on iOS (#1726) @Deloyuri<https://secure-web.cisco.com/1233B7Gmixa7xnzojSoR3mmaEm2PTmXlu49g-JQGmcj923PofpB_WB3so5fe_EMNijSQnuK4qZlLOW9mUEmTooYM8onJ9dAGQ3rPUnoo8wuayzYaKxqpKGUdi5l9lmwA1YVa4O_9P1Dt3VdYj2gSMqkiAktS5sE4F1dGLPJwlHzUdNNINW-doQXIR6D2mo5ARjulXdjCiZFMbhp-axzbJS6d7I6NOjB9liAdgeLW3RF7FojQq3DUClp_Uua6W5u-9u0maqKKP7LeNwUDhNk9b1kpH3iquii9Psq09WS-cJegV1m1cERcQBxyrdqpEaVL6lhptJ8ZIfWNF5EZt-7d5_Xhspr3ZH4aTeJsQRi4Vz5-vApJsWfCq5P-IuiAUsOIb_60AlQK5A9q55n_f6bG1kpPNFw0-iPhfAvxHI4h_PKdHR230lFoEOGyxqZyQsXtCCnUE5yHHdi4Ems3GJoSvxUjd6DJ28zWDDJvDoAK46Eo_0PFIjMSAwTLfhmdqgARkQDT6e74n_q5wUqqBLYbSlQ/https%3A%2F%2Fgithub.com%2FDeloyuri> have you considered moving to MSAL.NET? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://secure-web.cisco.com/1obgLo1fv_IEczhhjft24NchNluVXQH87EghMHFvlLucWl1qHOU4LEeJGwgQeeSuQTFZP_ye4uzuxnf6eplxlHjgZV06iPPer1mJIe5KWmvcr0ET7MFj0DfCtAyqoClg_9tLTyBpLVXw4xyqhND4XP7lGsIjAFQzJ2-yYj7GjaLs1GV1KQUyb3APfFG0eYt-x3CRf8Wo9T9HoDyrdBpU9qYNn1ryVNzh7sluaIsgqDvJagROtGqRdrZpiWFj8wMbF64o3QoED4PpehQcOzBK-Ie0Pr_R2BJ4Yyotx_vvr7ddcHQn_Cl1-vsFnJVJlCJ-hOOQBmo024xxYUd8DY8Nz_-xh81uAODG9TQaQdquhdLVUuxfneNjUtcoH6fu8m5MQJi-iHgHKkzZhIHf2hUjy1HnPB_9CeFqUSb43xObM8Qbsi91vlTexowV9ApXeza7heFIU5MBdccIKtCWCnp-BKPNqHweUaENNmGfTBpX_ANNwIadthRNk2gGuj-3RMjlSLGH2civN3fEvKFPbOwyEnw/https%3A%2F%2Fgithub.com%2FAzureAD%2Fazure-activedirectory-library-for-dotnet%2Fissues%2F1726%23issuecomment-823361460>, or unsubscribe<https://secure-web.cisco.com/1TdVKYY6JIlrMqZ7VF3Q-H1d2fCWFjQKu0xLcVM7cAswwFrXuLk--YACDqrypvABoOtoJi_5vANgJTfxXPEnNTpBkFxTb-2x9EGFjlu9MlM7DtpJZ8AKuLoVx2JNRAD3cSVBy-f0atGSMiVuE5CYi_9jslCmdVueB3zKReTIWgNfUYRZvNU6TfHvRtUWA1TdMKuQO12S2SdUjU_3UBKyZb0ksSZPfdDNfChkFhe0FI_QuwoxKj3Jm3nIu2zVcqqBtMNavEXKjsWvUhFiVSKRzT3e_lqq4M1OW6xToa3hpHhuCb_b4pyMZ34bnVPXnf0BPoYiEt_mODeS4LEYmZw3nRoQMw2bnaLE1QZ0r_d-jhzOiaXEABT8oQQAe-Q8XQkF3RxGHnSfuUcXztEOJykM7UnTMHpETSw7pCP8WdUnLzTtWc6tKNEzPAjDkScQMGGTZQF5jlzhs88ODU8YkiPG3PGibjeUjA2Ws7D9vPiyQ0heuiJ5Xb1NhCtSIN3fn4znaIveELX3fz-CZrRTPGGDCfQ/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHOW4CHJ26YNMWM4SYFEQLLTJWLVBANCNFSM43HWM2NA>.

[jennyf19]

@Deloyuri i understand.

Which xamarin version are you on?

You can pass in an HttpClientFactory for iOS...can you try passing in one that uses the managed handler, which doesn't care about the app going into the background and see if that one works? You would do something like this for the iOS factory:

azure-activedirectory-library-for-dotnet/src/Microsoft.IdentityModel.Clients.ActiveDirectory/Core/Http/HttpClientFactory.cs

Line 59 in bc9b6cc

_httpClient = new HttpClient(new HttpClientHandler() { UseDefaultCredentials = true })

Providing an HttpClient · https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/wiki/Providing-an-HttpClient

[jennyf19]

@Deloyuri i would suggest passing in the HttpClient, as the solution. It shouldn't be a huge change in your code, do you have a test environment where you can try it?

and which version of Xamarin is being used?

[bgavrilMS]

@jennyf19 - note that injecting an HttpClient was implemented sometime in ADAL 5.x, pretty sure it isn't possible in ADAL 3.x. Why would a custom HttpClient fix this issue? Are you thinking about the recent Xamarin SDK bug?

[jennyf19]

@bgavrilMS i would like to see if the managed httpclient is not working as well, either netcore/mono has the issue.

@Deloyuri, as @bgavrilMS mentioned, you would need to move to latest ADAL version first.

recent Xamarin SDK bug

it wasn't a bug in Xamarin, it was a bug in the customer code.

[jennyf19]

also @Deloyuri I gave our css engineer the link to the MSAL.NET repro, and not ADAL.NET, sorry about that, but @jmprieur got it sorted out

[Deloyuri]

you guys lost me a bit. As @bgavrilMS mentioned, the version of ADAL we have doesn't allow for swapping out HttpClient. Has anyone on your team been able to reproduce this? I'd suggest trying with the same version of ADAL as above, and on an iOS 14.5 beta device.

[jennyf19]

@Deloyuri we can try to repro on the latest version, but not on 3.x. our suggestion would be to use the HttpClient, as I mentioned above. Or move to MSAL.NET

[Deloyuri]

Please let me know what you see when you try to reproduce with ADAL and iOS 14.5 beta.

[bgavrilMS]

@Deloyuri - just to set expectations, we do support ADAL 5.x but not ADAL 3.x. Each major version of the library has 1 year support from the team. We are not setup to repro ADAL 3.x bugs, we always ask developers to upgrade (ideally to MSAL, as making changes in ADAL is unlikely).

[Deloyuri]

Ok, got it. Are you able to reproduce with ADAL 5.x?

[jennyf19]

@Deloyuri yes, @trwalke is on point to try and repro w/5.x and iOS 14.5

[jennyf19]

@Deloyuri can you try updating to Xamarin iOS 14.14 and see if the issue repros there? There is an issue in mono, so you can either update the Xamarin iOS version to 14.14 or try passing in your own HttpClient, or updating to MSAL. Probably the move to 14.14 is least invasive to your app.