MsalCacheHelper.CreateAsync throws MsalClientException when using an ADFS ClientId

[azuread]

MsalCacheHelper.CreateAsync throws MsalClientException when using an ADFS ClientId

[bgavrilMS]

The workaround mentioned here will ensure token caching works, however the event CacheChanged will not fire.

[jmprieur]

@bgavrilMS this is really an MSAL.NET issue? if the ADFS client ID needs to be a GUID, do we want to relax the constraint in MSAL.NET when we detect an ADFS authority?

[bgavrilMS]

@jmprieur - it's not an MSAL.NET issue, it is a cache extension issue.

[bgavrilMS]

As discussed offline - the cache needs to be able to read the accounts and only MSAL can do that. So the cache creates a PublicCLientApplication object with the given client ID, but this doesn't work for ADFS / other cloud authorities.

Solution would be for users to provide authority as well.

[jmprieur]

Todo:

1. Add a new property Authority to StorageCreationPropertiesBuilder, which default value is the Azure public cloud authority
2. Have MsalCacheHelper.GetAccountIdentifiersNoLockAsync use the authority when creating the public client application