Giter Site home page Giter Site logo

Comments (5)

quark17 avatar quark17 commented on July 22, 2024

I see that you've submitted a PR for this. Thank you, I'll review it. BSC should definitely be generating a unique name.

For years, the only supported syntax was BSV, because the target users were hardware designers that were familiar with Verilog and SystemVerilog, not Haskell. The Haskell-based "Classic" syntax (which we're now calling BH) was maintained, but new features weren't added to it and nearly no one wrote designs in it. The BSV syntax natively supports SystemVerilog preprocessor directives (it preserves position information etc) and so I don't think anyone ever used CPP, instead preferring the SV PP. The Classic/BH syntax obviously doesn't have SV preprocessor support, so you have to use CPP. Recently, there's been interest in using the Classic/BH syntax, and those Classic/BH tutorial examples were added to help those folks. I assume that as more people start using the BH front-end, we'll see requests for fixes like this and for features (to make the BH front-end catch up with the BSV front-end).

from bsc.

cbiffle avatar cbiffle commented on July 22, 2024

That's a great point that this affects only the "classic" frontend. I didn't realize that (as I've been working with classic).

I think I've seen this bug manifest without -cpp on the command line, but I'm going to have to check my notes carefully before I assert that more forcefully.

from bsc.

quark17 avatar quark17 commented on July 22, 2024

The _t_o_p.c name should be fixed with commit e5af869. Do any other interferences occur?

from bsc.

bpfoley avatar bpfoley commented on July 22, 2024

@cbiffle Gentle poke... is this working for you now?

from bsc.

quark17 avatar quark17 commented on July 22, 2024

For reference: Above, I mentioned that I'd fixed it with commit e5af869, but I reverted that (with commit e0aab35) and accepted @cbiffle 's original solution for this (PR #52) with merge commit 8bcfc18.

from bsc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.