Giter Site home page Giter Site logo

Comments (5)

davidribeiro avatar davidribeiro commented on May 19, 2024

Hi @mbabker
Is this issue still open? I can take a look at it if you want to

from pagerfanta.

mbabker avatar mbabker commented on May 19, 2024

Yes, it's still open.

from pagerfanta.

davidribeiro avatar davidribeiro commented on May 19, 2024

I can take a look at this if you want. Just tell me what branch should I use, I see that 2.x is the default one but there are branches as well I think

from pagerfanta.

mbabker avatar mbabker commented on May 19, 2024

The 2.x branch is fine since it's the oldest supported, I'll handle upmerging to 3.x whenever a pull request is merged.

And thanks for taking a look, I just don't work with MongoDB and don't know the Doctrine package well enough to do anything meaningful here.

from pagerfanta.

davidribeiro avatar davidribeiro commented on May 19, 2024

Done in #19
Unfortunately, there's not a lot we can do since the Doctrine ODM package has this issue:

  • \Doctrine\ODM\MongoDB\Query\Builder::getQuery should return some type of QueryInterface (and this interface should implement the \IteratorAggregate Interface)
  • This way the \Doctrine\ODM\MongoDB\Query\Query class could be final but any unit tests would still be able to work without any kind of "bypassFinals"

from pagerfanta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.